ref(dsyms): Prefer debug ids over code ids #95861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
vgrozdanic
approved these changes
Jul 18, 2025
loewenheim
reviewed
Jul 18, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95861 +/- ##
==========================================
- Coverage 87.74% 80.43% -7.32%
==========================================
Files 10582 10582
Lines 610032 610048 +16
Branches 23976 23976
==========================================
- Hits 535276 490683 -44593
- Misses 74472 119081 +44609
Partials 284 284 |
vgrozdanic
reviewed
Jul 18, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
vgrozdanic
approved these changes
Jul 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 21, 2025
Only fallback to a code id search if there is no 'perfect' match for a
debug id.
Example SQL query:
```sql
(
SELECT "sentry_projectdsymfile"."id" AS "col1",
"sentry_projectdsymfile"."file_id" AS "col2",
"sentry_projectdsymfile"."checksum" AS "col3",
"sentry_projectdsymfile"."object_name" AS "col4",
"sentry_projectdsymfile"."cpu_name" AS "col5",
"sentry_projectdsymfile"."project_id" AS "col6",
"sentry_projectdsymfile"."uuid" AS "col7",
"sentry_projectdsymfile"."code_id" AS "col8",
"sentry_projectdsymfile"."data" AS "col9",
"sentry_projectdsymfile"."date_accessed" AS "col10",
"sentry_file"."id" AS "col11",
"sentry_file"."name" AS "col12",
"sentry_file"."type" AS "col13",
"sentry_file"."timestamp" AS "col14",
"sentry_file"."headers" AS "col15",
"sentry_file"."size" AS "col16",
"sentry_file"."checksum" AS "col17",
"sentry_file"."blob_id" AS "col18",
"sentry_file"."path" AS "col19"
FROM "sentry_projectdsymfile"
INNER JOIN "sentry_file"
ON (
"sentry_projectdsymfile"."file_id" = "sentry_file"."id")
WHERE (
"sentry_projectdsymfile"."uuid" = dfb8e43a-f242-3d73-a453-aeb6a777ef75
AND "sentry_projectdsymfile"."project_id" = 4556436849360897))
UNION
(
SELECT "sentry_projectdsymfile"."id" AS "col1",
"sentry_projectdsymfile"."file_id" AS "col2",
"sentry_projectdsymfile"."checksum" AS "col3",
"sentry_projectdsymfile"."object_name" AS "col4",
"sentry_projectdsymfile"."cpu_name" AS "col5",
"sentry_projectdsymfile"."project_id" AS "col6",
"sentry_projectdsymfile"."uuid" AS "col7",
"sentry_projectdsymfile"."code_id" AS "col8",
"sentry_projectdsymfile"."data" AS "col9",
"sentry_projectdsymfile"."date_accessed" AS "col10",
"sentry_file"."id" AS "col11",
"sentry_file"."name" AS "col12",
"sentry_file"."type" AS "col13",
"sentry_file"."timestamp" AS "col14",
"sentry_file"."headers" AS "col15",
"sentry_file"."size" AS "col16",
"sentry_file"."checksum" AS "col17",
"sentry_file"."blob_id" AS "col18",
"sentry_file"."path" AS "col19"
FROM "sentry_projectdsymfile"
INNER JOIN "sentry_file"
ON (
"sentry_projectdsymfile"."file_id" = "sentry_file"."id")
WHERE (
"sentry_projectdsymfile"."code_id" = ae0459704fc7256
AND "sentry_projectdsymfile"."project_id" = 4556436849360897
AND NOT EXISTS
(
SELECT 1 AS "a"
FROM "sentry_projectdsymfile" u0
WHERE (
u0."uuid" = dfb8e43a-f242-3d73-a453-aeb6a777ef75
AND u0."project_id" = 4556436849360897) limit 1)))
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only fallback to a code id search if there is no 'perfect' match for a debug id.
Example SQL query: