fix(spans-migration): Lock down discover transactions tab completely

[nikkikapadia]

As part of the spans migration, we're locking down the transactions dataset in discover completely. This will not allow users to select the transactions dataset and save changes to existing transaction queries. I had to make changes to the TabList.Item component to allow passing in tooltip props so i can display the deprecation message.

Closes ENG-4633

[linear]

ENG-4633 Lock existing discover query edit and transaction tab

[narsaynorath]

I see this is used a few places, should we put it into some helper function where we can provide the trace URL?

[narsaynorath]

It seems like when disabled: true, the tooltip hovering doesn't work. You may want to see if there's some kind of styling blocking cursor events 🤔

[narsaynorath]

I think this line is responsible. Maybe we can check if there's tooltip information in the styled component before blocking all pointer events, or maybe there's another setting that we can use.

[cursor]

Bug: Tooltips Fail on Disabled Tabs

Tooltips do not display for disabled tabs. Although the Tooltip component wraps the BaseTab, the BaseTab (via its internal TabWrap component) applies pointer-events: none CSS styling when disabled. This styling prevents mouse hover events from reaching the Tooltip wrapper, making it non-functional and defeating the purpose of providing explanatory tooltips for disabled tabs.

static/app/components/core/tabs/tab.tsx#L172-L193

sentry/static/app/components/core/tabs/tab.tsx

Lines 172 to 193 in 199b167

	if (tooltipProps) {
	return (
	<Tooltip {...tooltipProps}>
	<BaseTab
	tabProps={tabProps}
	isSelected={isSelected}
	to={to}
	hidden={hidden}
	disabled={disabled}
	orientation={orientation}
	overflowing={overflowing}
	ref={objectRef}
	variant={variant}
	as={as}
	size={size}
	>
	{rendered}
	</BaseTab>
	</Tooltip>
	);
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎