-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(cell-action): add external linking as action #95892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(cell-action): add external linking as action #95892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 ! Two questions:
- In a few places the
isUrl
functionality is checking the feature flag, but sometimes not, is that intentional? - I'm worried that people won't remember to import
handleCellActionFallback
, and this'll result in inconsistent fallback handling. Is it possible to handle the fallback insideCellActions
?
@gggritso I think we would need to refactor how Would it be better to split it into two helper functions (e.g., |
@lzhao-sentry I like that idea! Go for it 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Changes
Have external linking as a dropdown menu option for
CellAction
. Removed cell actions for some ID linked fields (since it conflicts with the dropdown & should just directly open the link)Video
external.linking.mov