feat(cell-action): add external linking as action

[lzhao-sentry]

Changes

Have external linking as a dropdown menu option for CellAction. Removed cell actions for some ID linked fields (since it conflicts with the dropdown & should just directly open the link)

Video

external.linking.mov

[gggritso]

👀 ! Two questions:

1. In a few places the isUrl functionality is checking the feature flag, but sometimes not, is that intentional?
2. I'm worried that people won't remember to import handleCellActionFallback, and this'll result in inconsistent fallback handling. Is it possible to handle the fallback inside CellActions?

[lzhao-sentry]

2. I'm worried that people won't remember to import handleCellActionFallback, and this'll result in inconsistent fallback handling. Is it possible to handle the fallback inside CellActions?

@gggritso I think we would need to refactor how handleCellAction works since there's no consistent way to know if an action was successfully handled. We could add a return type, but I feel like that puts more work on the user.

Would it be better to split it into two helper functions (e.g., copyToClipboard and openExternalLink)? I know it turns it into two imports, but I think the naming makes it clear the purpose of the functions?

[gggritso]

@lzhao-sentry I like that idea! Go for it 👍🏻

[gggritso]

👍🏻

[lzhao-sentry]

@gggritso Apologies, need a re-review. Was showing this to Dora and Dhrumil and they asked for logs to still use the ellipsis trigger since the bold hover trigger doesn't fit well there. I added an extra prop and enum to support this

[cursor]

Bug: Clipboard Copy Triggers Unnecessary Query Update

The Actions.COPY_TO_CLIPBOARD case was removed from the handleCellAction switch statement. Copy actions now fall through to the default case, which calls updateQuery. This unnecessarily executes query modification logic and browser history navigation, despite updateQuery handling the copy internally.

static/app/views/discover/table/tableView.tsx#L611-L625

sentry/static/app/views/discover/table/tableView.tsx

Lines 611 to 625 in 8deae8f

	}
	default: {
	// Some custom perf metrics have units.
	// These custom perf metrics need to be adjusted to the correct value.
	let cellValue = value;
	const unit = tableData?.meta?.units?.[column.name];
	if (typeof cellValue === 'number' && unit) {
	if (Object.keys(SIZE_UNITS).includes(unit)) {
	// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
	cellValue *= SIZE_UNITS[unit];
	} else if (Object.keys(DURATION_UNITS).includes(unit)) {
	// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
	cellValue *= DURATION_UNITS[unit];
	}
	}

Fix in Cursor • Fix in Web

---

[cursor]

Bug: Feature Flag Naming Error

The discover-cell-actions-v2 feature flag check is missing the organizations: prefix, it should be organizations:discover-cell-actions-v2.

Locations (4)

• static/app/views/discover/table/cellAction.tsx#L305-L306
• static/app/utils/discover/fieldRenderers.tsx#L334-L335
• static/app/utils/discover/fieldRenderers.tsx#L530-L531
• static/app/views/explore/tables/fieldRenderer.tsx#L246-L247

Fix in Cursor • Fix in Web

[gggritso]

Logs is the only table to use the ellipsis trigger.

:cryblood: