Skip to content

ref(insights): rename EAPSpanProperty to SpanProperty #95902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DominikB2014
Copy link
Contributor

Renaming this, no need to specify it's EAP now that there is only one dataset

@DominikB2014 DominikB2014 requested review from a team as code owners July 18, 2025 18:15
Copy link

linear bot commented Jul 18, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 18, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 This ties in nicely with Tony's PR that start splitting these definitions up! We'll probably need to be more careful in the future about typing and naming responses from EAP (spans vs. logs vs. whatever other telemetry becomes available).

@DominikB2014 DominikB2014 merged commit f46f9f7 into master Jul 22, 2025
46 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/dain-756-update-type-of-usespanseries-to-be-spanproperty branch July 22, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants