-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
🔧 chore(jira): prevent EventLifecycle flow errors #95936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Logging Removal Masks Assignment Errors
The logger.info("inbound-assignee-not-found", extra=log_context)
call was unintentionally removed during refactoring to consolidate halt recording logic. This eliminates per-instance logging when an assignee is not found, significantly reducing debugging and monitoring visibility for assignment issues.
src/sentry/integrations/utils/sync.py#L132-L141
sentry/src/sentry/integrations/utils/sync.py
Lines 132 to 141 in 33a7b34
groups_assigned.append(group) | |
else: | |
assignee_not_found = True | |
if assignee_not_found: | |
lifecycle.record_halt( | |
ProjectManagementHaltReason.SYNC_INBOUND_ASSIGNEE_NOT_FOUND, extra=log_context | |
) | |
return groups_assigned |
Was this report helpful? Give feedback by reacting with 👍 or 👎
assignee_not_found = True | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add to the log context which users weren't found ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exercise left for the developer 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jk its caused i already merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💀
resolves ECO-883
instead of recording halts multiple times, lets check if we need to record a halt and then do it.