CUDA: add mean operation #14313
Merged
CUDA: add mean operation #14313
+54
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
JohannesGaessler
approved these changes
Jun 21, 2025
There was a problem hiding this comment.
Since you're already working on reduction ops, you could take a look at the discussion in ggml-org/ggml#1005 . The person who said they'd do it has so far not delivered anything so I think it's safe to say they won't in the future.
For the CUDA code specifically my preference would be to have the reduction ops in a single file so that the template and the code using it is close together but this is a minor issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor sum_rows to use also do norm. Added a performance test as well. Sum-rows and mean can be abstracted even more but I think it's a cleaner API to keep them like this.