Skip to content

fix inverted strcmp checking for quantize --keep-split #7374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2024
Merged

fix inverted strcmp checking for quantize --keep-split #7374

merged 1 commit into from
May 19, 2024

Conversation

fredlas
Copy link
Contributor

@fredlas fredlas commented May 18, 2024

No description provided.

@ggerganov ggerganov merged commit 1ea2a00 into ggml-org:master May 19, 2024
@mofosyne
Copy link
Collaborator

CI failed at

https://github.com/ggml-org/ci/tree/results/llama.cpp/1e/a2a0036e88172d6c8bf7e1a1989a03894dc955/ggml-2-x86-cpu#test_scripts_debug

I can't find the error message for it however in the log?

@mofosyne mofosyne mentioned this pull request May 20, 2024
Closed
ggerganov added a commit that referenced this pull request May 20, 2024
@ggerganov
tests : fix --keep_split -> --keep-split (#7374)
2789baf
@ggerganov
Copy link
Member

This should fix it: 2789baf

@mofosyne
Copy link
Collaborator

CI issue fixed by #7409

@fredlas fredlas deleted the fix_cmdline_arg_strcmp branch March 17, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredlas @mofosyne @ggerganov