Avoid access violations when running Bash with TERM=msys

[dscho]

We used to set the environment variable TERM=msys in Git for Windows 1.x, so we should handle it gracefully with Git for Windows 2.x, too. Certainly an access violation is the wrong thing to do, ideally we handle msys as a synonym to cygwin.

[Alexpux]

ncurses don't have msys terminal so need always use cygwin

[dscho]

It does not crash when TERM=xterm. In fact, it seems it only crashes whenever TERM is set to a value that does not correspond to a directory in /usr/share/terminfo/??/. That is probably a problem we want to fix in any case.

[dscho]

@Alexpux BTW why is ncurses-devel a build dependency, but ncurses not a runtime dependency?

[Alexpux]

Dependency of what?

[Alexpux]

Package ncurses itself is in group base so it always present in MSYS2 from the installer.

[dscho]

Dependency of what?

Whoops, sorry: bash (I still think of this ticket as "Avoid access violations when running Bash").

[Alexpux]

bash is linked fully static, so it depends only from msys-2.0.dll

[dscho]

Package ncurses itself is in group base so it always present in MSYS2 from the installer.

Okay. I generally prefer the dependencies in a package management system to be set up correctly because it is as much documentation as it is necessary for proper process of Pacman.

[dscho]

bash is linked fully static, so it depends only from msys-2.0.dll

That explains it.

[Alexpux]

I'm create bash and pacman packages statically linked to simplify process of update core packages.