Release 2.22.0 breaks side-band for git protocol #2278
Description
Setup
- Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
v2.22.0.windows.1 64-bit
$ git --version --build-options
git version 2.22.0.windows.1
cpu: x86_64
built from commit: d003d728ffa6c0006da875ec6318d3f6b28a4ddb
sizeof-long: 4
sizeof-size_t: 8
- Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
Windows 7 Pro SP1
$ cmd.exe /c ver
Microsoft Windows [Version 6.1.7601]
- What options did you set as part of the installation? Or did you choose the
defaults?
# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt
Editor Option: Nano
Custom Editor Path:
Path Option: BashOnly
SSH Option: OpenSSH
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: MinTTY
Performance Tweaks FSCache: Enabled
Use Credential Manager: Disabled
Enable Symlinks: Disabled
Enable Builtin Interactive Add: Disabled
- Any other interesting things about your environment that might be related
to the issue you're seeing?
Internally using the git protocol to local git server on Ubuntu 16.04 (running git-daemon).
Running "git config --list" on local system shows:
sendpack.sideband=false
which allowed the git protocol to be used with git v2.21.0 or earlier.
Details
- Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other
bash
- What commands did you run to trigger this issue? If you can provide a
Minimal, Complete, and Verifiable example
this will help us understand the issue.
git clone git://serverip/project.git
cd project
; make project changes here
git add files-that-changed
git commit
git push ; git will hang here
- What did you expect to occur after running these commands?
That the push would have succeeded and not hung.
- What actually happened instead?
The git push command hangs.
- If the problem was occurring with a specific repository, can you provide the
URL to that repository to help us with testing?
Will fail on any repo that we access using the git protocol. The SSH protocol is OK.
I looked at the git-for-windows source code and noticed that the code to handle sideband=false is missing in send-pack.c for v2.22.0. This code was present for previous releases of git-for-windows but is no longer there for v2.22.0.
I've attached the commit that is present for v2.21.0 and is NOT present for v2.22.0. The previous commits for send-pack.c are identical so only this last commit is missing.