Installer - Allow /CloseApplications to do what it needs to ensure that silent install/upgrades complete successfully

[ferventcoder]

As a user installing/upgrading silently, if something like ssh-agent is running, it can cause the process to hang or fail. It would be nice to be able to pass something like /CLOSEAPPLICATIONS to signify that "Yes, I am sure I would like everything closed so the install/upgrade can continue".

For a GUI based installer, I agree with @sschuberth on "it simply does not feel right to kill ssh-agent without asking the user first." However, for a silent install, a user should be able to pass something that signifies that they are okay with moving forward with whatever is necessary to make the install/upgrade happen successfully.

The relevant code blocks look to have moved over to https://github.com/git-for-windows/build-extra/blob/9f0c810c3872e335218833157272cde7d9f6b7a8/installer/install.iss.in#L349-L418

Follow up from msysgit/msysgit#249.

[dscho]

Thanks for following up. I agree with the reasoning. @ferventcoder have you managed to build an installer using the new Git for Windows SDK yet? If so, could you just patch in the relevant usr\bin\ssh-agent.exe lines and see whether it Does The Right Thing?

[ferventcoder]

I'm good to help out, I haven't attempted to build with the new SDK yet. :)

[dscho]

@ferventcoder could you do that? I'll need you to test things with the new SDK anyway...

[dscho]

@ferventcoder once you installed the Git for Windows SDK, you can make an installer using the silent-install branch.

If that manages to find the ssh-agent and close it, I will merge said branch. Could you please test?

[ferventcoder]

Will do. Hopefully today.

[ferventcoder]

Attempted to extract produced an issue:

I don't need a proxy.

[ferventcoder]

I think a reboot may be necessary.

ping dl.bintray.com times out.

[dscho]

ping dl.bintray.com times out.

That is correct, dl.bintray.com does not answer.

But does it resolve, that is the question... If in doubt, you could either switch to Google's DNS (8.8.8.8) or put the entry "5.153.24.114 dl.bintray.com" into your C:\Windows\system32\drivers\etc\hosts.

Or maybe just restarting the SDK installer will work around that problem?

[ferventcoder]

Or maybe just restarting the SDK installer will work around that problem?

Gave it a couple of shots. I decided on a reboot to see if that clears things out. The next step is to flush the dns cache, as that was not the IP address that the machine in question attempting to ping. :/

Usually use Google's DNS, but I'll check for sure. I believe it is a local machine issue.

[ferventcoder]

Do you think the issue is possibly a permission-related issue with regards to bintray?

These items don't show up, but that doesn't mean they won't work.
Based on mirrorlist.git-for-windows:

• https://bintray.com/git-for-windows/pacman/mingw/
• https://bintray.com/git-for-windows/pacman/msys2/

These don't have any public direct downloads:

• https://bintray.com/git-for-windows/pacman/package-database/view
• https://bintray.com/git-for-windows/pacman/pacman/view

[ferventcoder]

No, that's not the issue. If I keep trying enough times, it works. :/ Definitely something with my machine.

[ferventcoder]

Okay, got something built, will test in a little while and give you a heads up. :)

[dscho]

Thanks!