C++: Support printing of global and namespace variables in PrintAST

[jketema]

Also rename shouldPrintFunction to shouldPrintDeclaration, as an initial step towards this.

[MathiasVP]

One small comment, but otherwise this LGTM!

[MathiasVP]

Also: I assume you tried this locally and double checked the that performance is fine on a non-trivial database? I remember we've had issues in the past with these VSCode-related queries not being tested on DCA and not noticing a join-order issue.

[jketema]

Also: I assume you tried this locally and double checked the that performance is fine on a non-trivial database? I remember we've had issues in the past with these VSCode-related queries not being tested on DCA and not noticing a join-order issue.

Good point. I tried this on one file in one database, but maybe I should do a bit more extensive testing. Do you have any suggestions for a database/files on which I should try this?

[MathiasVP]

Good point. I tried this on one file in one database, but maybe I should do a bit more extensive testing. Do you have any suggestions for a database/files on which I should try this?

If I were to point to a really evil file I'd point you to https://raw.githubusercontent.com/wireshark/wireshark/master/epan/dissectors/packet-rrc.c (which exists in the Wireshark DB you can download from DCA) 😄.

[jketema]

Good point. I tried this on one file in one database, but maybe I should do a bit more extensive testing. Do you have any suggestions for a database/files on which I should try this?

If I were to point to a really evil file I'd point you to https://raw.githubusercontent.com/wireshark/wireshark/master/epan/dissectors/packet-rrc.c (which exists in the Wireshark DB you can download from DCA) 😄.

Either with and without the change VSCode is not able to render the file:

Reading bqrs data failed with args:
    bqrs decode -v --log-to-stderr --format json --entities=id,url,string --result-set nodes /var/folders/ls/pjlfr1pd7_lfd3zkf6bs1rl00000gn/T/queries_-53148-B7zLvImBA6GV/contextual-query-storage/printAst.ql-l2Kn-8kMvGRFEfKAt60ZJ/results.bqrs
Error: Cannot create a string longer than 0x1fffffe8 characters (codeQL.viewAstContextEditor)

The time it takes to get to that point is roughly similar

[MathiasVP]

Ah, yes. That's a VSCode issue I guess 😭

[jketema]

Ah, yes. That's a VSCode issue I guess 😭

I've tried this on some other files in the same Wireshark directory. The speed doesn't seem to have changed significantly on those files.

[MathiasVP]

LGTM!