Java: Use nested names in MaD signatures. #14032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atorralba
approved these changes
Aug 24, 2023
atorralba
added a commit
to atorralba/codeql
that referenced
this pull request
Aug 25, 2023
Re-generated the Jenkins and Stapler models to pick up the changes from github#14032
| --- | ||
| category: minorAnalysis | ||
| --- | ||
| * Fixed the MaD signature specifications to use proper nested type names. |
There was a problem hiding this comment.
Maybe it is worth updating the soon to be public documentation: https://github.com/github/codeql/blob/main/docs/codeql/codeql-language-guides/customizing-library-models-for-java.rst?plain=1#L293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/github/codeql-java-team/issues/346
I've left a test query between the first two commits that I also used in a top 1000 MRVA run to find models that needed an update. I've updated those that I found in that run, except for the auto-generated jenkins models.