Skip to content
This repository was archived by the owner on Sep 22, 2022. It is now read-only.

Add support for Shadow DOM & convert to TypeScript #56

Merged
merged 7 commits into from
May 6, 2020
Merged

Add support for Shadow DOM & convert to TypeScript #56

merged 7 commits into from
May 6, 2020

Conversation

muan
Copy link
Contributor

@muan muan commented May 4, 2020

Similar to github/clipboard-copy-element#26.

Essentially whenever we want document we should retrieve rootNode from the current context.

On getRootNode() (spec):

  • Calling it on an element inside a standard web page will return an HTMLDocument object representing the entire page.
  • Calling it on an element inside a shadow DOM will return the associated ShadowRoot.

And DocumentOrShadowRoot is where we get activeElement from.

muan added 5 commits May 3, 2020 00:38
@muan
Fix use cases in Shadow DOM
1c18373 
Instead of calling document directly we should use getRootNode() to
retrieve the right context.

This fix will ensure dialogs in shadow root's tabbing behavior is
correctly trapped.
@muan
Add a Shadow DOM example
1f3336d
@muan
Convert to TypeScript and modernize build
b0ac326
@muan
Pull shadow dom demo code out
498566d
@muan
Add test in Shadow DOM context
d4223cb
@muan muan requested a review from a team May 4, 2020 19:50
koddsson
koddsson approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me ✨

keithamus
keithamus approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

muan and others added 2 commits May 6, 2020 14:22
@muan @koddsson
HTMLAnchorElement is HTMLElement
2d3c6c9 
Co-authored-by: Kristján Oddsson <[email protected]>
@muan @dgraham
Add new line at EOF
8667d74 
Co-authored-by: David Graham <[email protected]>
@muan muan merged commit 8862388 into master May 6, 2020
@muan muan deleted the shadowDOM branch May 6, 2020 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@keithamus keithamus keithamus approved these changes

@koddsson koddsson koddsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muan @keithamus @koddsson