No New notifications after update to 4.4

[eMerzh]

🔍 Is there already an issue for your problem?

• I have checked older issues, open and closed

📝 Description

Hey 👋

thanks for updating this app 🚀

it seems that me and a few others have issues to retrieve new notifications.

i relogged, restart.. doesn't seems to help

🪜 Steps To Reproduce

1. start app
2. get notification
3. nothing happens

ℹ System Info

Mac 13.5.2 (22G91) 
latest 4.4.0

📸 Screenshots

No response

[afonsojramos]

Do you have notifications enabled for the app on MacOS?

[kpurdon]

As a data point, installed the previous version and all notifications immediately came through.

[eMerzh]

oh sorry that wasn't clear ... i meant github notifications 😬 ....
funnyliy enough i got at notif for this one .... now that i try to redo that i can't...

if you want a screenshot :

[hackinghieser]

I have the same problem. Going back to v4.3.1 solved the issue.

[afonsojramos]

@kpurdon @eMerzh @AlexanderHieser can you try to disable colors? I have a suspicion... Also, did you login with GitHub or using a token? If with a token, with which scopes?

[eMerzh]

@afonsojramos hum ... it seems to be related to colors indeed
(but i like colors 🥺)

note: i need to quit/restart to apply the setting (on or off)

ftr I used the token to login...

[afonsojramos]

I think that for the colors it may require the repo scope, which the previous version did not have. The repo scope was introduced here: #538
I'll try to take a look if there is something that can be done.

[dberuben]

same issue

[cleardemon]

Hi there, just wanted to give confirmation that either disabling colours or updating the token with repo scope makes notifications appear in Gitify again in 4.4.

[ponkio-o]

Hi, I'm having the same problem with Github Enterprise Server. I tried repo scope permission granted but it didn't show up.
Does anyone else have a similar problem??

[rbclark]

I ended up having to log out and log back in which fixed things for me. After the re-auth I received the following email from Github:

Previously, a third-party OAuth application (Gitify) had notifications and read:user scopes. It was recently granted an additional scope (repo).

Potentially related? #606

[bmulholland]

@rbclark Yes, you got it, see #624 (comment)

Unfortunately we don't have a flow to request updated scopes, and doing that would be a bunch of work. We could add a fallback to not use colors, though that also wouldn't be great. I think that's the only two options? Dropping colors doesn't make sense, it's a nice feature.

[rbclark]

@bmulholland I think the most clear thing would be logging out the user if they don't have the proper scopes and requiring them to re-authenticate. It took me the whole week of not getting notifications before I investigated since I didn't realize anything was wrong since it was silently failing.

[bmulholland]

Yeah that's an easy enough idea. @afonsojramos what do you think?