[prebuilds] workspace starts with derived config, wrong image, and no prebuild

[AlexTugarev]

Happened once for me yesterday, I started a workspace on g/g but ended up with a derived config, wrong workspace image and no prebuild.

When digging through the logs, I've seen the following error message, which is related to a recent change in #14461

did not find a finished prebuild in the database despite waiting long enough after msgbus confirmed that the prebuild had finished

There are ~200 entries found in EU server logs. Unsure if this is a cause for the issue, nor is this directly translates to the number of affected workspaces.

[geropl]

We should definitely investigate how this can happen. @AlexTugarev Do you have any IDs, so we can investigate on a specific data set? Or at least a link to the logs?

Scheduled for next week. 📔

[AlexTugarev]

I've added the link to the error logged for my workspace where I started the investigation for.

[nhorton]

I am getting an error which might be related. When users kick off workspaces with just the gitpod.io prefix to the github.com url, it does not use the prebuilds, and in fact does not run the init before letting the user in, so everything breaks badly.

[svenefftinge]

@nhorton How do users start workspaces when the prebuilds do work? Asking because workspaces are always started with the prefix URL, no matter you start them from Gitpod dashboard or GitHub. Are the users members of the team that owns the project?

[svenefftinge]

That path for the mentioned warning message is only reached if waiting for finishing prebuild is enabled. I had previously proposed to remove all this logic and never wait for prebuilds that are in progress. WDYT @geropl?

[nhorton]

When users start from the prebuild badge or action on GitHub, it often does not use the prebuild. That link is always there, it is just reachable from prebuild status page under the status, including when Ready. I know at least some of the affected users are team members as this affects me myself.

…

On Mon, Dec 12, 2022, 12:53 AM Sven Efftinge ***@***.***> wrote: That path for the mentioned warning message is only reached if waiting for finishing prebuild is enabled. I had previously proposed to remove all this logic and never wait for prebuilds that are in progress. WDYT @geropl <https://github.com/geropl>? — Reply to this email directly, view it on GitHub <#14726 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABR24UIDLZNQVYGOOBHGUDWM3KXBANCNFSM6AAAAAASB5XAEE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.