adding new profile fields for new onboarding flow #16467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-bmh-lead-enrichment-new-profile-fields.1 because the annotations in the pull request description changed |
selfcontained
force-pushed
the
bmh/lead-enrichment-new-profile-fields
branch
from
7654102 to
d4cb653
Compare
selfcontained
changed the title
|
/hold for feedback |
geropl
reviewed
Feb 21, 2023
| @@ -254,6 +254,16 @@ export interface ProfileDetails { | |||
| companyName?: string; | |||
| // the user's email | |||
| emailAddress?: string; | |||
| // the user's company website | |||
There was a problem hiding this comment.
Feels a bit unrelated, but: I have zero clue what this ProfileDetails is used for. Feels like a merge-leftover.
The actual shape we're using is Profile (see above). 😕
geropl
approved these changes
Feb 21, 2023
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a few new optional profile fields that we'll collect during some upcoming onboarding flow changes.
companyWebsiteWe'll be asking for a user's company website instead of company. Rather than re-purposingcompany, creating a new field as we experiment here.jobRoleThis will be a response to us asking what a user's role is at their job. It will be a string value that we'll map to a list of options, such asfrontend,backend, data_analytics`, etc (actual list still tbd, but we'll keep this as a flexible string.jobRoleOther- When user selects "Other" as their jobRole, we'll allow them to optionally provide a freeform value here.signupGoals- This will be a response to us asking the user what they hope to accomplish when signing up with Gitpod. It will also be a string value that maps to a list of options we'll provide them.signupGoalsOther- When user selects "Other" forsignupGoalswe'll let them optionally provide a freeform value here.How to test
Nothing to test currently, this just sets up some new optional fields that we'll begin using in subsequent PRs.
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh