Dockerfiles enhanced to support ARM64 #7937

ZCube · 2022-02-01T05:29:33Z

Description

Dockerfiles enhanced to support ARM64. GitPod can be built on ARM64.

Related Issue(s)

How to test

Build GitPod on arm64 using docker image ghcr.io/zcube/workspace-images/gitpod-dev:arm64

To build the frontend, you need the arm64 binary of grpc-tool. It can be found at https://github.com/ZCube/grpc-precompiled-binaries.

replaces package.json
from

"grpc-tools": "^1.11.2"

to

"grpc-tools": "https://zcube.github.io/grpc-precompiled-binaries/grpc-tools.tar.gz"

The build was tested using github jobs at https://github.com/zcube/gitpod/tree/arm64-2

After modifying the rendered yaml in the installer, it mostly works like this.

node0 : ARM64
nodex86 : x86

MySQL cannot run on ARM64.

Release Notes

NONE

P.S

I developed this with RedstoneWizard08 to solve ARM64 Support #7700. But suddenly RedstoneWizard08 and the issue disappeared together.

csweichel · 2022-02-01T09:10:07Z

/werft run

👍 started the job as gitpod-build-zb-arm64-build-fork.0

codecov · 2022-02-01T09:19:25Z

Codecov Report

Merging #7937 (60c20d3) into main (bbf7036) will decrease coverage by 1.80%.
The diff coverage is n/a.

❗ Current head 60c20d3 differs from pull request most recent head 9fd97d0. Consider uploading reports for the commit 9fd97d0 to get more accurate results

@@            Coverage Diff             @@
##             main    #7937      +/-   ##
==========================================
- Coverage   12.01%   10.20%   -1.81%     
==========================================
  Files          20       18       -2     
  Lines        1190     1009     -181     
==========================================
- Hits          143      103      -40     
+ Misses       1043      905     -138     
+ Partials        4        1       -3

Flag	Coverage Δ
components-gitpod-cli-app	`10.20% <ø> (-0.66%)`	⬇️
components-local-app-app-darwin-amd64	`?`
components-local-app-app-darwin-arm64	`?`
components-local-app-app-linux-amd64	`?`
components-local-app-app-linux-arm64	`?`
components-local-app-app-windows-386	`?`
components-local-app-app-windows-amd64	`?`
components-local-app-app-windows-arm64	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/gitpod-cli/cmd/credential-helper.go	`1.20% <0.00%> (-4.39%)`	⬇️
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf7036...9fd97d0. Read the comment docs.

csweichel · 2022-02-02T14:43:08Z

/werft run

👍 started the job as gitpod-build-zb-arm64-build-fork.1

RedstoneWizard08 · 2022-02-02T15:27:17Z

Hi! I'm back!
Here's the long version of what happened: #7700 (comment)
TL;DR: My account got suspended, I didn't do anything wrong, and everything's okay now. I may work on this issue a little more (the issue has re-appeared) but I think @ZCube has done mostly everything! Thanks so much for your help!

Original issue: #7700

geropl · 2022-02-03T15:24:00Z

/lgtm

I tested the amd64 build by starting workspaces and it worked as expected. I also checked the pods/deployments, also as expected. 🎉

I see this as first step to eventually support ARM platforms. IMO it would make sense to also offer arm64 images, because it has already started taking shares of cloud space (AWS) and will continue to do so.

Some thoughts around building additional arm64 images:

we should build them as often as possible (on every build, ideally), without slowing down the build 🐔 🥚
to make that work we could:
- only build arm64 on main builds
- run arm64 builds in a parallel job

roboquat · 2022-02-03T15:24:06Z

LGTM label has been added.

Git tree hash: de3bb443246bb5c0bbbec610609a151fcd6d13fc

ZCube · 2022-02-03T16:28:50Z

Hi! I'm back! Here's the long version of what happened: #7700 (comment) TL;DR: My account got suspended, I didn't do anything wrong, and everything's okay now. I may work on this issue a little more (the issue has re-appeared) but I think @ZCube has done mostly everything! Thanks so much for your help!

Original issue: #7700

Thanks to you, I was able to get started, and your point was very helpful. In particular, I received a lot of help in building a test environment using Github Actions.

roboquat · 2022-02-03T16:36:48Z

New changes are detected. LGTM label has been removed.

ZCube · 2022-02-03T16:42:08Z

/lgtm

I tested the amd64 build by starting workspaces and it worked as expected. I also checked the pods/deployments, also as expected. 🎉

I see this as first step to eventually support ARM platforms. IMO it would make sense to also offer arm64 images, because it has already started taking shares of cloud space (AWS) and will continue to do so.

Some thoughts around building additional arm64 images:

we should build them as often as possible (on every build, ideally), without slowing down the build 🐔 🥚

to make that work we could:

only build arm64 on main builds

run arm64 builds in a parallel job

I finally managed to run it. Does it work using MariaDB? The only one that requires amd64 is MySQL.

RedstoneWizard08 · 2022-02-03T19:42:49Z

@ZCube we still need to update the helm chart to support arm64. I've already started doing this. https://github.com/gitpod-io/gitpod/tree/main/chart

RedstoneWizard08 · 2022-02-03T19:43:48Z

https://gitpod-arm.github.io/gitpod-arm-chart/helm/

csweichel · 2022-02-04T08:49:08Z

@ZCube please squash the commits - I'll then re-run the CI and I reckon we're good to go

roboquat · 2022-02-04T11:21:06Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: geropl
To complete the pull request process, please assign jeanp413, kylos101 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jeanp413 @kylos101 in a comment when ready.

Associated issue: #7700

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

~~OWNERS~~ [geropl]
~~components/dashboard/OWNERS~~ [geropl]
components/docker-up/OWNERS
~~components/gitpod-db/OWNERS~~ [geropl]
components/ide/OWNERS
components/ide-proxy/OWNERS
components/image-builder-bob/OWNERS
components/image-builder-mk3/OWNERS
~~components/proxy/OWNERS~~ [geropl]
components/workspacekit/OWNERS
components/ws-daemon/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ZCube · 2022-02-04T11:24:23Z

@csweichel I squash the commit. I probably won't have to fix it any more. Sorry for bothering you with the commit.

princerachit · 2022-02-08T05:08:56Z

Hi, there seems to be a conflict. Can you please resolve it?

ZCube · 2022-02-08T13:48:31Z

Hi, there seems to be a conflict. Can you please resolve it?

@princerachit In order to resolve this conflict, I have to modify the part related to the gitpod/openvscode-server-linux-build-agent docker image, but I can't do it. I was lost as to where to start.

# Conflicts: # components/ide/code/leeway.Dockerfile

RedstoneWizard08 · 2022-02-08T16:15:23Z

@ZCube fun little problem. this image doesn't support arm64.
https://hub.docker.com/r/gitpod/openvscode-server-linux-build-agent/tags

https://hub.docker.com/layers/gitpod/openvscode-server-linux-build-agent/stretch-arm64/images/sha256-908fd91b4b9801324075904ba8a0907ec6ce7d94695e80ac22746d9e4b9180c5?context=explore
This one says it does, but it's compiled on amd64, so it doesn't work.

RedstoneWizard08 · 2022-02-08T16:17:32Z

However, we do have this repo:
https://github.com/gitpod-io/vscode-linux-build-agent

RedstoneWizard08 · 2022-02-08T18:36:46Z

https://github.com/gitpod-arm/vscode-linux-build-agent

RedstoneWizard08 · 2022-02-08T20:11:48Z

Hi, there seems to be a conflict. Can you please resolve it?

@princerachit In order to resolve this conflict, I have to modify the part related to the gitpod/openvscode-server-linux-build-agent docker image, but I can't do it. I was lost as to where to start.

@ZCube I created a vscode-linux-build-agent clone and modified it to support arm64.

https://github.com/gitpod-arm/vscode-linux-build-agent/actions/runs/1814282344

akosyakov · 2022-02-16T08:08:10Z

@csweichel how we are going to maintain it? It seems to add some complexity to IDE images

csweichel · 2022-02-17T09:02:59Z

Hi @ZCube - thank you for the effort you've put into this.
After plenty of internal discussion we've come to the conclusion that at this point we'd rather not merge the PR, because:

we as Gitpod, and our customers today, don't have the use-case to run Gitpod on ARM64
we would not be able to guarantee that the ARM64 support would not break down the road, making this a very unreliable feature,
of the complexity, albeit a surprisingly small number of necessary changes.

I am sorry I don't have better news. Also, the statements above reflect our reasoning at this time, and things might change down the road.

roboquat added release-note-none team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team size/M labels Feb 1, 2022

gtsiolis added the community-contribution label Feb 1, 2022

roboquat assigned geropl Feb 3, 2022

roboquat added the lgtm label Feb 3, 2022

ZCube requested review from a team February 3, 2022 16:36

roboquat added team: IDE and removed lgtm labels Feb 3, 2022

ARM64 Support.

5f99b8a

ZCube force-pushed the zb/arm64-build branch from bc54801 to 5f99b8a Compare February 4, 2022 11:20

Merge remote-tracking branch 'origin3/main' into zb/arm64-build

9fd97d0

# Conflicts: # components/ide/code/leeway.Dockerfile

roboquat added size/L and removed size/M labels Feb 8, 2022

gtsiolis added the do-not-merge/cla-pending CLA has not been signed label Feb 11, 2022

csweichel closed this Feb 17, 2022

princerachit mentioned this pull request Mar 3, 2022

Any plans to support arm64? gitpod-io/workspace-images#744

Closed

axonasif mentioned this pull request Mar 8, 2022

ARM64 support not working #8509

Closed

lucasvaltl mentioned this pull request Aug 2, 2022

[local-preview] Add Arm (and Mac M1) support #11309

Closed

lucasvaltl mentioned this pull request Aug 12, 2022

Waiting for Admin Console to be ready ⠦Error: - Self Hosted #11478

Closed

Dockerfiles enhanced to support ARM64 #7937

Dockerfiles enhanced to support ARM64 #7937

Uh oh!

Conversation

ZCube commented Feb 1, 2022

Description

Related Issue(s)

How to test

Release Notes

P.S

Uh oh!

csweichel commented Feb 1, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

csweichel commented Feb 2, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RedstoneWizard08 commented Feb 2, 2022

Uh oh!

geropl commented Feb 3, 2022

Uh oh!

roboquat commented Feb 3, 2022

Uh oh!

ZCube commented Feb 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roboquat commented Feb 3, 2022

Uh oh!

ZCube commented Feb 3, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RedstoneWizard08 commented Feb 3, 2022

Uh oh!

RedstoneWizard08 commented Feb 3, 2022

Uh oh!

csweichel commented Feb 4, 2022

Uh oh!

roboquat commented Feb 4, 2022

Uh oh!

ZCube commented Feb 4, 2022

Uh oh!

princerachit commented Feb 8, 2022

Uh oh!

ZCube commented Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RedstoneWizard08 commented Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RedstoneWizard08 commented Feb 8, 2022

Uh oh!

RedstoneWizard08 commented Feb 8, 2022

Uh oh!

RedstoneWizard08 commented Feb 8, 2022

Uh oh!

akosyakov commented Feb 16, 2022

Uh oh!

csweichel commented Feb 17, 2022

Uh oh!

Uh oh!

csweichel commented Feb 1, 2022 •

edited by werft-gitpod-dev-com bot

Loading

codecov bot commented Feb 1, 2022 •

edited

Loading

csweichel commented Feb 2, 2022 •

edited by werft-gitpod-dev-com bot

Loading

ZCube commented Feb 3, 2022 •

edited

Loading

ZCube commented Feb 3, 2022 •

edited by werft-gitpod-dev-com bot

Loading

ZCube commented Feb 8, 2022 •

edited

Loading

RedstoneWizard08 commented Feb 8, 2022 •

edited

Loading