HTML sanitizer doesn't allow centering of text

[alexanderadam]

• Gitea version (or commit ref): 1.12.0+dev-379-ge5944a952
• Git version: irrelevant
• Operating system: irrelevant
• Database: irrelevant
• Can you reproduce the bug at https://try.gitea.io:
  • Yes: https://try.gitea.io/alexanderadam/636f7374-cherry.cr
• Log gist: irrelevant

Description

See the missing icon in the README of this mirror on try.gitea.io whereas the rendering on GitHub is flawless. (see #8830 for the image issue).

The text centering of the headline is lost.

Screenshots

[jolheiser]

The first issue is a duplicate of #8830

The second is because of our sanitizer not allowing align = "center".

[zeripath]

If instead of writing html you used markdown syntax for the image - it would work as expected.

We don't currently munge the relative URL of a IMG elements - I guess we could and it is likely to be a very simple pr to do that.

[alexanderadam]

The first issue is a duplicate of #8830

Ah I see. I searched for it and found nothing. I will remove the part about the relative path in this issue then.
Thank you for pointing out 👍

If instead of writing html you used markdown syntax for the image - it would work as expected.

1. It isn't my repository. I just took a random repository from GitHub and mirrored it on try.gitea.io. I obviously can't control random repositories on the web. 😉
2. So the logic between Markdown and HTML rendering is diverged (= buggy)

[zeripath]

see #10515 for dealing with the embedded html img tags ...

[alexanderadam]

Awesome, thank you Andrew!

[alexanderadam]

Thank you so much for fixing those both issues, @zeripath.
I'm afraid I found another markdown/html rendering issue which isn't fixed in the current build on try.gitea.io. Or is the current master not yet deployed?

Should I open a new issue for this or recycle this one?

[zeripath]

Open a new one

[alexanderadam]

done. Thank you again for fixing those issues so fast.
And you are even answering blazingly fast. 😉