-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Description
- Gitea version (or commit ref): 1.13.0+dev-434-gdcb543ac2
- Git version: 2.17.1
- Operating system: Ubuntu 18.04.5 LTS
- Database (use
[x]
):- PostgreSQL
- MySQL
- MSSQL
- SQLite
- Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL): https://try.gitea.io/saagarjha/review-comment-shift/pulls/1
- No
- Not relevant
- Log gist:
Description
Gitea seems to associate review comments to a commit and a line number, however, this does not really play well with people adding commits that modify the code that the commits point to. For example, it will mark something as "outdated" if it is merely shifted around in such a way that that line shows up as modified, even though there has been no logical change the the line that it tracks. Depending on the situation, sometimes it will not detect a change but the comment will not move along with other changes in the file–if I make a comment at line 50 and then line 30 gets deleted in a subsequent commit, sometimes it will still show the comment at line 50 even though it "should" now be at line 49.
Screenshots
The comment has completely disappeared from here:
and is "Outdated" here:
even though logically I haven't actually touched those lines.