Skip to content

Comment association should work on the hunk, not the line, level #12722

@saagarjha

Description

@saagarjha

Description

Gitea seems to associate review comments to a commit and a line number, however, this does not really play well with people adding commits that modify the code that the commits point to. For example, it will mark something as "outdated" if it is merely shifted around in such a way that that line shows up as modified, even though there has been no logical change the the line that it tracks. Depending on the situation, sometimes it will not detect a change but the comment will not move along with other changes in the file–if I make a comment at line 50 and then line 30 gets deleted in a subsequent commit, sometimes it will still show the comment at line 50 even though it "should" now be at line 49.

Screenshots

The comment has completely disappeared from here:

Screen Shot 2020-09-04 at 16 49 01

and is "Outdated" here:

Screen Shot 2020-09-04 at 16 49 25

even though logically I haven't actually touched those lines.

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue/needs-feedbackFor bugs, we need more details. For features, the feature must be described in more detailtype/bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions