Documentation should be more explicit, that things like LOCAL_ROOT_URL require a trailing slash

[p-kraszewski]

Feature Description

Hey y'all!

Thank you for an excellent project!

However, I've spent most of the today chasing, why any access via ssh:// ended with uninformative "Internal error". Only after enabling dev mode and trace logging level it appeared gitea serv connected back to the daemon with wrong path.

DOC/FAQ should be much more explicit, that LOCAL_ROOT_URL should be a path to gitea web interface reachable from localhost and must have a trailing slash (this may be the case of you concatenating path elements manually instead of using path.Join(...))

Screenshots

No response

[silverwind]

I think we better just append a absent slash to the parsed variable if it's really crucial.

[p-kraszewski]

It is crucial, as without it the SSH helper performs requests on www.mydomain.comapi/....

if !strings.HasSuffix(setting.LocalURL,`/`){
   setting.LocalURL=setting.LocalURL+`/`
}

Another way is to avoid things like

reqURL := setting.LocalURL + "api/internal/mail/send"

and replace it with

// I'm not sure of the performance impact
reqURL := path.Join(setting.LocalURL,"api/internal/mail/send")

or

// Double slash would do no harm and relative paths aren't valid here.
reqURL := setting.LocalURL + "/api/internal/mail/send"

However, your way is the least error-prone as of now (do it once, during the parsing of the config file)

[p-kraszewski]

Wow, that escalated quickly...