500 error opening certain mirrored repositories on gitea.com

[Fogapod]

Description

Opening oldest repository on gitea.com as unauthorized user causes 500 page to be shown. I have no additional context to attach there.
Repo: https://gitea.com/gitchain/gitchain

Gitea Version

1.17.0+dev-631-g5976e3e89

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

I don't

Database

No response

[techknowlogick]

Specific error is:

2022/06/07 23:42:55 ...s/context/context.go:231:HTML() [E] [629f71fe-62] Render failed: template: repo/header:40:191: executing "repo/header" at <MirrorRemoteAddress $.Context $.Mirror>: error calling MirrorRemoteAddress: runtime error: invalid memory address or nil pointer dereference
	/source/modules/context/context.go:231 (0x1aeae6c)
	/source/routers/web/repo/view.go:973 (0x2021ab9)
	/source/routers/web/repo/view.go:729 (0x201faef)
	/source/modules/web/wrap_convert.go:44 (0x1f0e136)
	/source/modules/web/wrap.go:41 (0x1f0c449)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x170ad35)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/source/modules/web/wrap.go:63 (0x1f0c8cf)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/source/modules/web/wrap.go:63 (0x1f0c8cf)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/source/modules/web/wrap.go:63 (0x1f0c8cf)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/middleware/get_head.go:37 (0x1f725e4)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/source/modules/web/wrap.go:63 (0x1f0c8cf)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/source/modules/context/context.go:800 (0x1af0c7a)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:71 (0x1708b6c)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:314 (0x170a51b)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x170ad35)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/source/routers/web/base.go:173 (0x21424f1)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/go/pkg/mod/gitea.com/go-chi/session@v0.0.0-20211218221615-e3605d8b28b8/session.go:257 (0x15108fd)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/source/modules/web/wrap.go:110 (0x1f0d368)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:71 (0x1708b6c)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:314 (0x170a51b)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x170ad35)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/source/routers/common/middleware.go:79 (0x1f77be2)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/source/modules/web/routing/logger_manager.go:123 (0x1f0816f)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/middleware/strip.go:30 (0x1f75358)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x1f71c56)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/source/routers/common/middleware.go:32 (0x1f77a32)
	/usr/local/go/src/net/http/server.go:2084 (0x926b8e)
	/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:88 (0x1708b21)
	/source/modules/web/route.go:200 (0x1f0b88d)
	/usr/local/go/src/net/http/server.go:2916 (0x92a17a)
	/usr/local/go/src/net/http/server.go:1966 (0x925636)
	/usr/local/go/src/runtime/asm_amd64.s:1571 (0x4700c0)

2022/06/07 23:42:55 ...eb/routing/logger.go:99:func1() [I] [629f71fe-62] router: completed GET /gitchain/gitchain for 1.2.3.4:12345, 500 Internal Server Error in 98.8ms @ repo/view.go:715(repo.Home)

[Fogapod]

Found another one: https://gitea.com/gitea/gitea_mirror
Not sure if these cause the same error. Both problematic repositories are mirrors

[zeripath]

I suspect this might have already been fixed by #19864

[lunny]

https://gitea.com/gitchain/gitchain

Looks like not

[Fogapod]

Both repos work now. Don't know which commit fixed it

[lunny]

#19959 fixed this issue