Show deprecated config settings in UI

[jolheiser]

Feature Description

https://github.com/go-gitea/gitea/blob/main/modules/setting/config_provider.go could be expanded to also collect deprecated settings and show them on the UI (perhaps in the Admin interface?).

I'm not sure whether a banner message or notification would serve better in this regard.

This may be easier than grepping logs for deprecated settings.

Screenshots

No response

[wxiaoguang]

I think it needs a "self-check" page (ref :#24392 (comment) )

What about adding a "self check" page in site admin?
It could do a full self check, including:

1. database versions (pgsql, mysql, etc)
2. database charsets (mysql), not only just checking default, but check all columns.
3. reverse proxy rewriting and sub path (eg: is %2F kept?)
4. system time (to resolve incorrect OTP problems)
5. system health like free disk, etc

And a lot of errors/warnings can be shown there (including "Add logs to tell users they should move some of their legacy custom public files" in #25974)

For the "config options", I think we also need our own INI package to see whether a config option is really read(used). If any config key is not used, it should also remind the users that "you have misconfiguration in your app.ini", it could avoid a lot of low-level mistakes.

[lunny]

Not only a self-check page, maybe it should also a self-fix page?

[wxiaoguang]

Only a few can be fixed by Gitea itself.

But Gitea can fix none of "database version", "incorrect config", "proxy rewriting", "system time", "free disk" and even more.

[lunny]

We can also have a topbar warning like ROOT_URL which only displayed on admin panel or admin's UI.

[delvh]

Don't show the user things that are only intended for admins.

[lunny]

Don't show the user things that are only intended for admins.

Of course it should not.

[delvh]

Ah, so only show it for admins?
That sounds like a better idea.
You mean something like The site config seems outdated, please have a look in the admin panel?

[lunny]

Ah, so only show it for admins? That sounds like a better idea. You mean something like The site config seems outdated, please have a look in the admin panel?

Yes, and when click, it will display a page which will list all the deprecated configurations. I remember you have created a PR which do a similar thing?

[wxiaoguang]

Now they are shown on the "Self Check" page.

Feel free to reopen if I missed anything.