actions task displays an incorrect time

[ExplodingDragon]

Description

I'm using sqlite and found this bug during a routine weekly check, not sure how to reproduce it for now.

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

systemd

Database

SQLite

[yp05327]

The duration in the first pic is calculated by the records in action_run table,
and in the second pic, it is calculated by the records in action_task_step table.
So it seems that the data in action_task_step table is correct but the data in action_run table is incorrect.

[yp05327]

It seems that this run was scheduled twice.

yesterday (above the wrong duration) is Updated time. Not the Started time and Stopped time.
And the schedule is weekly, and the run before this run is 2 weeks ago, so the last updated time of this run should be 1 weeks ago? But it is yesterday here.

So I guess: yesterday it was scheduled again (or maybe other operations?) , and the Started time was updated.
But this run is already been done, so the status should be done and it would not run again.
So the Stopped time should be the last stopped time which won't be updated for ever, so the duration becomes minus number here.
So if my guess is correct, the date of yesterday would be about 105h37m21s after the real Stopped time.

[yp05327]

Ok, I got it. But don't know why. 🤔

[yp05327]

This issue is not related to cron job.
And there's a easy way to reproduce:

• stop all your runners which can pick up the workflow.
• trigger the workflow, and the status will be waiting as there's no runners to run it.
• cancel it, the status will become failure.
• start your runner, rerun it
• after it finished, you will get a minus duration time.

I will try to fix it. This issue is caused by the codes here:

gitea/models/actions/run_job.go

Lines 140 to 146 in 876a0cb

	run.Status = aggregateJobStatus(jobs)
	if run.Started.IsZero() && run.Status.IsRunning() {
	run.Started = timeutil.TimeStampNow()
	}
	if run.Stopped.IsZero() && run.Status.IsDone() {
	run.Stopped = timeutil.TimeStampNow()
	}

When a job finished before executed once, e.g. no target runner and canceled manually, the Stopped time is not 0 but the Started time is 0.
So if you rerun it, only Started time will be updated, but the Stopped time won't. Then you will get a minus duration time, as it is calculated by Stopped - Started.

[github-actions]

Automatically locked because of our CONTRIBUTING guidelines