"Ghost" user in issue list points 404 page, but should not be clickable

[tklein23]

• When a user creates an issue, then the name in the issue list is clickable and points to the profile (which is correct)
• When the user is deleted, then the name changes to "Ghost", but is still clickable and sends to 404 page (which is not correct)

The incorrect line in the template is:

• gitea/templates/repo/issue/list.tmpl

  Line 223 in 01bd1fc

  {{$.i18n.Tr .GetLastEventLabel $timeStr .Poster.HomeLink .Poster.Name | Safe}}

In other places ghost links are handled correctly:

• gitea/templates/repo/issue/view_title.tmpl

  Lines 39 to 43 in 01bd1fc

  	{{if gt .Issue.Poster.ID 0}}
  	{{$.i18n.Tr "repo.issues.opened_by" $createdStr .Issue.Poster.HomeLink .Issue.Poster.Name | Safe}}
  	{{else}}
  	{{$.i18n.Tr "repo.issues.opened_by_fake" $createdStr .Issue.Poster.Name | Safe}}
  	{{end}}

I was able to reproduce the bug in:

• https://try.gitea.io/
• https://github.com/Freeyourgadget/Gadgetbridge/issues

• Can you reproduce the bug at https://try.gitea.io:
  • Yes
  • No
  • Not relevant

[tklein23]

The example on try.gitea.io (issue #2 in the list) where Ghost should not be clickable:

• https://try.gitea.io/pippo/fsafsdfsd/issues

[lunny]

@tklein23 could you send a PR to fix that?

[tklein23]

tl;dr: Sorry, I can't do that.

A CR would require additional translations for issues.closed_by and issues.merged_by in all supported languages. IMO this is the wrong approach, because this increases the cost for adding new and supporting the existing languages.

Someone with more knowledge about the template language should probably see if it's possible to fix the macro and avoid having a "_fake" variant of each issue event.

Maybe I can do that once I'm more familiar with the gitea codebase, but for sure I cannot do it right now.

[adelowo]

You don't have to do all of the translations. Only the English one is needed, others will be added as needed on https://crowdin.com .

[oscarlofwenhamn]

I think I've fixed the issue in the above commit, but I'm not sure how to properly make a PR as I have another one pending, and committing seems to add it to that PR, sorry.