Syntax highlighting does not work in 1.9rc2

[fincham]

• Gitea version (or commit ref): 1.9.0+rc2-1-ga29e667ef built with GNU Make 4.1, go1.12.7 : bindata,
  sqlite, sqlite_unlock_notify
• Git version: 2.17.1
• Operating system: Ubuntu Bionic x86_64
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

In this release the code highlighting does not activate when viewing files, even though index.js seems to call it. The <code> element ends up with an empty class string and no highlighting occurs.

Downgrading to 1.8.3 fixes the problem.

[silverwind]

I can see this on try.gitea.io here. I suspect it might be related to the recent jQuery update on the 1.9 branch.

[silverwind]

Seems like some kind of race condition with the highlight. If I do a no-cache reload in Firefox (CTRL-Shift-R), it highlights correctly.

[fincham]

Thanks for checking that. try.gitea.io was too slow / broken for me to find any actual files yesterday to confirm :(

[archtaurus]

i put these in custom/templates/custom/header.tmpl to solve this problem for now ...

<link rel="stylesheet" href="//cdnjs.cloudflare.com/ajax/libs/highlight.js/9.15.8/styles/github.min.css">
<script src="//cdnjs.cloudflare.com/ajax/libs/highlight.js/9.15.8/highlight.min.js"></script>
<script>hljs.initHighlightingOnLoad();</script>

[fincham]

Hi there,

I'm now on 1.9.3 and this issue is still present, highlighting only activates maybe ~ 50% of the time on page loads :(

[lunny]

Could you try to clean the cache of browser?