Split some words from template to improve translation. #11221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
previously requested changes
Apr 26, 2020
options/locale/locale_en-US.ini
Outdated
| settings.add_team_duplicate = Team already has the repository | ||
| settings.add_team_success = The team now have access to the repository. | ||
| settings.search_team = Search Team... |
There was a problem hiding this comment.
Suggested change
| settings.search_team = Search Team... | |
| settings.search_team = Search Team… |
GiteaBot
added
the
lgtm/need 2
6543
requested changes
Apr 26, 2020
| @@ -66,7 +66,7 @@ | |||
| {{.Name}} | |||
| </a> | |||
| </div> | |||
| <div class="ui eight wide column poping up" data-content="Team's permission is set on the team setting page and can't be changed per repository"> | |||
| <div class="ui eight wide column poping up" data-content={{$.i18n.Tr "repo.settings.change_team_permission_tip"}}> | |||
There was a problem hiding this comment.
Suggested change
| <div class="ui eight wide column poping up" data-content={{$.i18n.Tr "repo.settings.change_team_permission_tip"}}> | |
| <div class="ui eight wide column poping up" data-content="{{$.i18n.Tr "repo.settings.change_team_permission_tip"}}"> |
| @@ -79,7 +79,7 @@ | |||
| {{end}} | |||
| </div> | |||
| {{if $allowedToChangeTeams}} | |||
| <div class="ui two wide column {{if .IncludesAllRepositories}}poping up{{end}}" {{if .IncludesAllRepositories}}data-content="This team has access to all repositories and can't be removed."{{end}}> | |||
| <div class="ui two wide column {{if .IncludesAllRepositories}}poping up{{end}}" {{if .IncludesAllRepositories}} data-content= {{$.i18n.Tr "repo.settings.delete_team_tip"}} {{end}}> | |||
There was a problem hiding this comment.
Suggested change
| <div class="ui two wide column {{if .IncludesAllRepositories}}poping up{{end}}" {{if .IncludesAllRepositories}} data-content= {{$.i18n.Tr "repo.settings.delete_team_tip"}} {{end}}> | |
| <div class="ui two wide column {{if .IncludesAllRepositories}}poping up{{end}}" {{if .IncludesAllRepositories}} data-content="{{$.i18n.Tr "repo.settings.delete_team_tip"}}"{{end}}> |
| @@ -96,15 +96,15 @@ | |||
| <div class="inline field ui left"> | |||
| <div id="search-team-box" class="ui search" data-org="{{.OrgName}}"> | |||
| <div class="ui input"> | |||
| <input class="prompt" name="team" placeholder="Search teams..." autocomplete="off" autofocus required> | |||
| <input class="prompt" name="team" placeholder={{$.i18n.Tr "repo.settings.search_team"}} autocomplete="off" autofocus required> | |||
There was a problem hiding this comment.
Suggested change
| <input class="prompt" name="team" placeholder={{$.i18n.Tr "repo.settings.search_team"}} autocomplete="off" autofocus required> | |
| <input class="prompt" name="team" placeholder="{{$.i18n.Tr "repo.settings.search_team"}}" autocomplete="off" autofocus required> |
6543
approved these changes
Apr 26, 2020
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #11221 +/- ##
==========================================
- Coverage 43.84% 43.83% -0.02%
==========================================
Files 607 607
Lines 86893 86893
==========================================
- Hits 38098 38086 -12
- Misses 44093 44104 +11
- Partials 4702 4703 +1
Continue to review full report at Codecov.
|
zeripath
approved these changes
Apr 29, 2020
GiteaBot
added
lgtm/done
|
@lafriks this needs your review |
|
make lg-tm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* split some words from template * split some words from template * add " " to mustache expression * split some words from template Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.