Skip to content

redirect .wiki/* ui link to /wiki #18831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 23, 2022
Merged

redirect .wiki/* ui link to /wiki #18831

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4923af3
redirect .wiki/* ui link to /wiki
a1012112796 Feb 20, 2022
bbf6a27
Merge branch 'main' into wiki_link
a1012112796 Mar 2, 2022
4d5b265
handle link
a1012112796 Mar 3, 2022
6f20718
Merge branch 'main' into wiki_link
a1012112796 Mar 3, 2022
3a23361
fix split logic
a1012112796 Mar 4, 2022
d5e55f1
Merge branch 'main' into wiki_link
a1012112796 Mar 4, 2022
d1f7961
Merge branch 'main' into wiki_link
a1012112796 Mar 5, 2022
e210502
Merge branch 'main' into wiki_link
a1012112796 Mar 17, 2022
8af14e7
Merge remote-tracking branch 'origin/main' into wiki_link
zeripath Mar 23, 2022
f3d5d7a
Correctly redirect using the similar code to the username redirect code
zeripath Mar 23, 2022
ac1bade
Placate lint
zeripath Mar 23, 2022
74db523
Merge branch 'main' into wiki_link
zeripath Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions modules/context/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,12 @@ func RepoAssignment(ctx *Context) (cancel context.CancelFunc) {
ctx.Repo.Owner = owner
ctx.Data["Username"] = ctx.Repo.Owner.Name

// redirect link to wiki
if strings.HasSuffix(repoName, ".wiki") {
ctx.Redirect(strings.Replace(ctx.Req.RequestURI, ".wiki", "/wiki", 1))
Copy link
Member

@silverwind silverwind Feb 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break on https://foo.wiki/user/repo.wiki?query=foo.wiki. Would at least include the repo name in the replacement, or properly parse the URL apart and join it again after replacement on the path.

return
}

// Get repository.
repo, err := repo_model.GetRepositoryByName(owner.ID, repoName)
if err != nil {
Expand Down