Skip to content

Fix profile render when the README.md size is larger than 1024 bytes #25131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 13, 2023
+116 −12
Merged

Fix profile render when the README.md size is larger than 1024 bytes #25131

Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7e84b56
fix
yp05327 Jun 8, 2023
71d8475
improve
yp05327 Jun 8, 2023
d5af147
remove code
yp05327 Jun 8, 2023
110196b
add 1024 limit for old use
yp05327 Jun 8, 2023
888cb8b
fix lint
yp05327 Jun 8, 2023
3afc0d2
depends on MAX_DISPLAY_FILE_SIZE
yp05327 Jun 13, 2023
d661b2c
Merge branch 'main' into fix-profile-render
GiteaBot Jun 13, 2023
f019480
Merge branch 'main' into fix-profile-render
GiteaBot Jun 13, 2023
d16e328
fix
yp05327 Jun 13, 2023
72c8f83
Update services/repository/files/content.go
wxiaoguang Jun 13, 2023
0e2e0d8
fix memory usage
wxiaoguang Jun 13, 2023
6f749e9
Merge branch 'main' into fix-profile-render
GiteaBot Jun 13, 2023
bc1f0ca
Merge branch 'main' into fix-profile-render
GiteaBot Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/git/blob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"encoding/base64"
"io"

"code.gitea.io/gitea/modules/setting"
"code.gitea.io/gitea/modules/typesniffer"
"code.gitea.io/gitea/modules/util"
)
Expand All @@ -21,13 +22,14 @@ func (b *Blob) Name() string {
}

// GetBlobContent Gets the content of the blob as raw text
// The max content size depends on MAX_DISPLAY_FILE_SIZE in app.ini
func (b *Blob) GetBlobContent() (string, error) {
dataRc, err := b.DataAsync()
if err != nil {
return "", err
}
defer dataRc.Close()
buf := make([]byte, 1024)
buf := make([]byte, setting.UI.MaxDisplayFileSize)
n, _ := util.ReadAtMost(dataRc, buf)
buf = buf[:n]
return string(buf), nil
Expand Down