x/tools/gopls: crash with invalid metadata containing blank package name

[Termina1]

gopls version: v0.12.3 (go1.20.2)
gopls flags:
update flags: proxy
extension version: 0.39.0
go version: 1.20.2
environment: Visual Studio Code darwin
initialization error: undefined
issue timestamp: Thu, 22 Jun 2023 16:03:59 GMT
restart history:
Thu, 22 Jun 2023 16:03:41 GMT: activation (enabled: true)

ATTENTION: PLEASE PROVIDE THE DETAILS REQUESTED BELOW.

Hi, I just opened VSCODE after update and gopls now crashing. I'm running MacBook m2, Ventura 13.1

[Info  - 19:03:42] 2023/06/22 19:03:42 go info for /Users/vyacheslavshebanov/Work/p2p/nitro
(go dir /Users/vyacheslavshebanov/Work/p2p/nitro)
(go version go version go1.20.2 darwin/arm64)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/Users/vyacheslavshebanov/Library/Caches/go-build, GOFLAGS=, GOMODCACHE=/Users/vyacheslavshebanov/go/pkg/mod, GOPATH=/Users/vyacheslavshebanov/go, GOPRIVATE=, GOROOT=/opt/homebrew/Cellar/go/1.20.2/libexec, GOWORK=])


[Info  - 19:03:43] 2023/06/22 19:03:43 go/packages.Load golang/vscode-go#1
	snapshot=0
	directory=file:///Users/vyacheslavshebanov/Work/p2p/nitro
	query=[/Users/vyacheslavshebanov/Work/p2p/nitro/... builtin]
	packages=144

[Info  - 19:03:43] 2023/06/22 19:03:43 go/packages.Load golang/vscode-go#1: updating metadata for 1135 packages

[Error - 19:03:43] 2023/06/22 19:03:43 computing the shared import graph: import failed for "github.com/ethereum/go-ethereum/metrics/exp": internal error: package name is "", want "genericconf" (id="github.com/ethereum/go-ethereum/metrics/exp", path="github.com/ethereum/go-ethereum/metrics/exp") (see issue #60904)

analysis.go:455: github.com/offchainlabs/nitro/solgen/go/bridgegen: invalid export data: internal error while importing "github.com/offchainlabs/nitro/solgen/go/bridgegen" (internal error: getPackages returned wrong name  for package "github.com/offchainlabs/nitro/solgen/go/bridgegen", want contracts); please report an issue
[Info  - 19:03:43] 
true
[Info  - 19:03:43] 2023/06/22 19:03:43 go info for /Users/vyacheslavshebanov/Work/p2p/nitro
(go dir /Users/vyacheslavshebanov/Work/p2p/nitro)
(go version go version go1.20.2 darwin/arm64)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/Users/vyacheslavshebanov/Library/Caches/go-build, GOFLAGS=, GOMODCACHE=/Users/vyacheslavshebanov/go/pkg/mod, GOPATH=/Users/vyacheslavshebanov/go, GOPRIVATE=, GOROOT=/opt/homebrew/Cellar/go/1.20.2/libexec, GOWORK=])


[Info  - 19:03:44] 2023/06/22 19:03:44 go/packages.Load golang/vscode-go#1
	snapshot=0
	directory=file:///Users/vyacheslavshebanov/Work/p2p/nitro
	query=[/Users/vyacheslavshebanov/Work/p2p/nitro/... builtin]
	packages=144

[Info  - 19:03:44] 2023/06/22 19:03:44 go/packages.Load golang/vscode-go#1: updating metadata for 1135 packages

[Error - 19:03:44] 2023/06/22 19:03:44 computing the shared import graph: import failed for "github.com/offchainlabs/nitro/solgen/go/rollupgen": internal error: package name is "", want "staker" (id="github.com/offchainlabs/nitro/solgen/go/rollupgen", path="github.com/offchainlabs/nitro/solgen/go/rollupgen") (see issue #60904)

analysis.go:455: github.com/offchainlabs/nitro/solgen/go/bridgegen: invalid export data: internal error while importing "github.com/offchainlabs/nitro/solgen/go/bridgegen" (internal error: getPackages returned wrong name  for package "github.com/offchainlabs/nitro/solgen/go/bridgegen", want contracts); please report an issue
[Info  - 19:03:44] 
true
[Info  - 19:03:44] 2023/06/22 19:03:44 go info for /Users/vyacheslavshebanov/Work/p2p/nitro
(go dir /Users/vyacheslavshebanov/Work/p2p/nitro)
(go version go version go1.20.2 darwin/arm64)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/Users/vyacheslavshebanov/Library/Caches/go-build, GOFLAGS=, GOMODCACHE=/Users/vyacheslavshebanov/go/pkg/mod, GOPATH=/Users/vyacheslavshebanov/go, GOPRIVATE=, GOROOT=/opt/homebrew/Cellar/go/1.20.2/libexec, GOWORK=])


[Info  - 19:03:45] 2023/06/22 19:03:45 go/packages.Load golang/vscode-go#1
	snapshot=0
	directory=file:///Users/vyacheslavshebanov/Work/p2p/nitro
	query=[/Users/vyacheslavshebanov/Work/p2p/nitro/... builtin]
	packages=144

[Info  - 19:03:45] 2023/06/22 19:03:45 go/packages.Load golang/vscode-go#1: updating metadata for 1135 packages

[Error - 19:03:45] 2023/06/22 19:03:45 computing the shared import graph: import failed for "github.com/ethereum/go-ethereum/consensus": internal error: package name is "", want "arbos" (id="github.com/ethereum/go-ethereum/consensus", path="github.com/ethereum/go-ethereum/consensus") (see issue #60904)

analysis.go:455: github.com/offchainlabs/nitro/solgen/go/bridgegen: invalid export data: internal error while importing "github.com/offchainlabs/nitro/solgen/go/bridgegen" (internal error: getPackages returned wrong name  for package "github.com/offchainlabs/nitro/solgen/go/bridgegen", want contracts); please report an issue
[Info  - 19:03:45] 
true
[Info  - 19:03:45] 2023/06/22 19:03:45 go info for /Users/vyacheslavshebanov/Work/p2p/nitro
(go dir /Users/vyacheslavshebanov/Work/p2p/nitro)
(go version go version go1.20.2 darwin/arm64)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/Users/vyacheslavshebanov/Library/Caches/go-build, GOFLAGS=, GOMODCACHE=/Users/vyacheslavshebanov/go/pkg/mod, GOPATH=/Users/vyacheslavshebanov/go, GOPRIVATE=, GOROOT=/opt/homebrew/Cellar/go/1.20.2/libexec, GOWORK=])


[Info  - 19:03:45] 2023/06/22 19:03:45 go/packages.Load golang/vscode-go#1
	snapshot=0
	directory=file:///Users/vyacheslavshebanov/Work/p2p/nitro
	query=[/Users/vyacheslavshebanov/Work/p2p/nitro/... builtin]
	packages=144

[Info  - 19:03:45] 2023/06/22 19:03:45 go/packages.Load golang/vscode-go#1: updating metadata for 1135 packages

[Error - 19:03:46] 2023/06/22 19:03:46 computing the shared import graph: import failed for "github.com/offchainlabs/nitro/solgen/go/rollupgen": internal error: package name is "", want "staker" (id="github.com/offchainlabs/nitro/solgen/go/rollupgen", path="github.com/offchainlabs/nitro/solgen/go/rollupgen") (see issue #60904)

analysis.go:455: github.com/offchainlabs/nitro/solgen/go/bridgegen: invalid export data: internal error while importing "github.com/offchainlabs/nitro/solgen/go/bridgegen" (internal error: getPackages returned wrong name  for package "github.com/offchainlabs/nitro/solgen/go/bridgegen", want contracts); please report an issue
[Info  - 19:03:46] 
true
[Info  - 19:03:46] 2023/06/22 19:03:46 go info for /Users/vyacheslavshebanov/Work/p2p/nitro
(go dir /Users/vyacheslavshebanov/Work/p2p/nitro)
(go version go version go1.20.2 darwin/arm64)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/Users/vyacheslavshebanov/Library/Caches/go-build, GOFLAGS=, GOMODCACHE=/Users/vyacheslavshebanov/go/pkg/mod, GOPATH=/Users/vyacheslavshebanov/go, GOPRIVATE=, GOROOT=/opt/homebrew/Cellar/go/1.20.2/libexec, GOWORK=])


[Info  - 19:03:46] 2023/06/22 19:03:46 go/packages.Load golang/vscode-go#1
	snapshot=0
	directory=file:///Users/vyacheslavshebanov/Work/p2p/nitro
	query=[/Users/vyacheslavshebanov/Work/p2p/nitro/... builtin]
	packages=144

[Info  - 19:03:46] 2023/06/22 19:03:46 go/packages.Load golang/vscode-go#1: updating metadata for 1135 packages

[Error - 19:03:46] 2023/06/22 19:03:46 computing the shared import graph: import failed for "github.com/offchainlabs/nitro/solgen/go/precompilesgen": internal error: package name is "", want "headerreader" (id="github.com/offchainlabs/nitro/solgen/go/precompilesgen", path="github.com/offchainlabs/nitro/solgen/go/precompilesgen") (see issue #60904)

analysis.go:455: github.com/offchainlabs/nitro/solgen/go/bridgegen: invalid export data: internal error while importing "github.com/offchainlabs/nitro/solgen/go/bridgegen" (internal error: getPackages returned wrong name  for package "github.com/offchainlabs/nitro/solgen/go/bridgegen", want contracts); please report an issue
[Error - 19:03:47] Connection to server got closed. Server will not be restarted.

[findleyr]

Thank you for the report. Is this an open-source repository?

[Termina1]

Yes, this is https://github.com/OffchainLabs/nitro

[findleyr]

Not reproducing immediately for me. Does this reproduce every time for you?

Which file are you opening to get this failure?

[Termina1]

Yes every time, arbnode/arbnode.go

[findleyr]

Thanks. I don't see that file in the master branch. Are you on a different branch?

[Termina1]

This one https://github.com/OffchainLabs/nitro/blob/master/arbnode/node.go

[findleyr]

Sorry, I'm having a tough time getting a valid go build in that project.

In the meantime, could you run this command and let me know if it outputs anything?

go run golang.org/x/tools/go/packages/gopackages -json -test -deps ./... | grep '""'

[findleyr]

Hrm, I do have a valid Go build now, and yet still don't reproduce. Could you also share your settings.json?

[adonovan]

I can reproduce the issue locally, just from cloning the repo and running gopls check ./arbnode/node.go. As I suspected, there are Metadata records being created with an empty Name field, plus an error. Specifically, for the github.com/offchainlabs/nitro/solgen/go/precompilesgen package:

util/headerreader/header_reader.go:21:2: github.com/VictoriaMetrics/fastcache@v1.6.0 (replaced by ./fastcache): reading fastcache/go.mod: open /Users/adonovan/w/nitro/fastcache/go.mod: no such file or directory

More generally, go list for this repo produces a bunch of errors and incomplete records that gopls appears not to be sanitizing sufficiently. (I realize this repo comes with additional instructions before one is expected to be able to run go build, but it shouldn't crash gopls.)

$ go list -deps -json ./arbnode/
{
        "Dir": "/Users/adonovan/w/nitro/util/headerreader",
        "ImportPath": "github.com/offchainlabs/nitro/util/headerreader",
 ...
        "Imports": [
                ...
                "github.com/offchainlabs/nitro/solgen/go/precompilesgen",
                ...
        ],
}
...
{
        "ImportPath": "github.com/offchainlabs/nitro/solgen/go/precompilesgen",
        "DepOnly": true,
        "Incomplete": true,
        "Stale": true,
        "StaleReason": "build ID mismatch",
        "Error": {
                "ImportStack": [
                        "github.com/offchainlabs/nitro/arbnode",
                        "github.com/offchainlabs/nitro/arbnode/dataposter",
                        "github.com/offchainlabs/nitro/util/headerreader"
                ],
                "Pos": "util/headerreader/header_reader.go:21:2",
                "Err": "github.com/VictoriaMetrics/fastcache@v1.6.0 (replaced by ./fastcache): reading fastcache/go.mod: open /Users/adonovan/w/nitro/fastcache/go.mod: no such file or directory"
        }
}

[findleyr]

Aha! Now I can reproduce as well. We're working on a fix.