-
Notifications
You must be signed in to change notification settings - Fork 18.3k
context: update doc comment to link to context interface #65768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Linking to the Context interface in the WithCancel doc comment makes it more consistent with the WithDeadline and WithTimeout doc comments.
This PR (HEAD: 9c6bb60) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564996. Important tips:
|
Message from Dmitri Shuralyov: Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/564996. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-17T04:48:07Z","revision":"25f9df2b67a3b63747c453d51e23dec2778b3bd6"} Please don’t reply on this GitHub thread. Visit golang.org/cl/564996. |
Message from Dmitri Shuralyov: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564996. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/564996. |
Message from Dmitri Shuralyov: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/564996. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/564996. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/564996. |
Linking to the Context interface in the WithCancel doc comment makes it more consistent with the WithDeadline and WithTimeout doc comments. Change-Id: Ic935c63e8262784be5f3564816402221ba2fbd63 GitHub-Last-Rev: 9c6bb60 GitHub-Pull-Request: #65768 Reviewed-on: https://go-review.googlesource.com/c/go/+/564996 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
This PR is being closed because golang.org/cl/564996 has been merged. |
Linking to the Context interface in the WithCancel doc comment makes
it more consistent with the WithDeadline and WithTimeout doc comments.