Create a type to represent metadata.img creation #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only called by assemble_cvd. Bug: b/425800170
There is currently an implicit ordering that [InitializeMiscImage](https://github.com/google/android-cuttlefish/blob/f6d691bf5cb8e337462929351ce45386af83424c/base/cvd/cuttlefish/host/libs/config/data_image.cpp#L251) must be run before [`BuildCompositeDiskIfNecessary`](https://github.com/google/android-cuttlefish/blob/05001207984a8a91e4a860fb7ac4b6dfcffe71a8/base/cvd/cuttlefish/host/commands/assemble_cvd/disk_flags.cc#L755) which is not obvious to a reader. Hiding the file path behind a type will make it possible to enforce that the file is created before other code can access the type. Bug: b/425800170
This path should be accessed through the MiscImage type. Bug: b/425800170
Databean
requested review from
cjreynol and
dimorinny
and removed request for
cjreynol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently an implicit ordering that InitializeMetadataImage must be run before
BuildCompositeDiskIfNecessarywhich is not obvious to a reader.Hiding the file path behind a type will make it possible to enforce that the file is created before other code can access the type.