fix(go/genkit): Reset knownpartials and helpers array for every new template #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apascal07
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(go/genkit): Reset knownpartials and helpers array for every new template [#312]
ISSUES:
[ ] #3019
CHANGELOG:
[ ] Add initialize method for template, knownpartials and knownhelpers fields in the dotprompt instance. This is done because every time a new prompt is compiled a new template is created using handlebars and then partials and helpers are registered for this template. Earlier only the template was created new but the knownhelpers and knownpartials arrays were not initialized again. This led to using knownhelpers and knownpartials for older template with the current template. And instead of registering the helpers and partials for the new template, error was thrown saying partials and helpers are already registered because they were already present in the knownpartials and knownhelpers arrays.