GTEST_AMBIGUOUS_ELSE_BLOCKER_ does not block the warning for gcc-7.1.

[gkistanova]

Starting from gcc 7.1 the GTEST_ASSERT_ and all the dependencies produce the following warning,
when used with if statement without surrounding braces.

It seems GTEST_AMBIGUOUS_ELSE_BLOCKER_ does not do the trick any more.

To reproduce, compile the following code

// gtest-ambiguous-else-warning.cpp
#include "gtest/gtest.h"

void foo(int i) {
  if (i > 0)
    GTEST_ASSERT_(::testing::AssertionFailure(), GTEST_NONFATAL_FAILURE_);
}

with

gcc-7.1 -Wall -c ./gtest-ambiguous-else-warning.cpp

The printout would be

./gtest-ambiguous-else-warning.cpp: In function 'void foo(int)':
./gtest-ambiguous-else-warning:4:6: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else]
   if (i > 0)
      ^

We observe the issue with Google Test 1.8.0, but as far as I can tell, it is the same in the current trunk.

[Bu11etmagnet]

I ran into this too (with gtest 1.7.0). This may be a bug in GCC. if () EXPECT_EQ() becomes something similar to

int main(int argc, char const *argv[])
{
  if (argc > 0) switch(0) case 0: default:
    if (argc > 1)
      return 2;
    else
      return 1;

  return 0;
}

after preprocessing and it seems pretty clear to me that the else cannot belong to the outside if.
clang correctly suppresses the warning.

[Bu11etmagnet]

https://stackoverflow.com/questions/44797011/google-tests-ambiguous-else-blocker-defeated-by-gcc-7-1

[gennadiycivil]

I have been cleaning up older and inactive GitHub googletest issues. You may see an issue "closed" if it appears to be inactive/abandoned
Thank you