This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Adding an emptyDir to kubernetes deployment
#380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should resolve the out-of-disk problems reported in #379
|
I will try to rebuild an image an check on test agent pool. Thank you, @ChristianKuehnel ! |
|
@ChristianKuehnel I have also documented steps I have done to verify PR before merging https://github.com/google/llvm-premerge-checks/wiki/LLVM-pre-merge-tests-operations-blog#2022-01-19 |
|
Thx for the documentation!
…--
Best,
Christian
Mikhail Goncharov ***@***.***> schrieb am Mi., 19. Jan. 2022,
17:55:
@ChristianKuehnel <https://github.com/ChristianKuehnel> I have also
documented steps I have done to verify PR before merging
https://github.com/google/llvm-premerge-checks/wiki/LLVM-pre-merge-tests-operations-blog#2022-01-19
—
Reply to this email directly, view it on GitHub
<#380 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYJMCGSN7ZNVQ6OOUI5RULUW3UJ7ANCNFSM5MJZZVRQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the out-of-disk problems reported in #379
Mounting an emptyDir volume for the Buildkite working directory should remove the disk space limitations from Kubernetes. So now it's only limited by the physical disc space available to the VM.
I did not check in detail but it looks like the ccache folder is also below
/var/lib/buildkite-agentso that should be covered as well.It might cause issues with the permissions. In that case we would probably need to change the permissions after the volume is mounted. So that would have to go into the
entrypoint.shscript.@metaflow Can you please review the change? I did not dare to apply it so far...