Allow to use random TCP port #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can have the system to allocate a random free TCP port by providing a value of "0" (int) to the port. If you try this in the current code, the callback fails because the URL hardcode port "0", which is wrong. This is quite easy to fix, by performing these two operations: 1) create the redirect URL only after having created the HTTP server 2) retrieve the TCP port from the HTTP server rather than from the configuration, and use the new value for the redirect URL
|
Interesting. As per Python 2 doc wsgiref.simple_server "implements a simple HTTP server (based on BaseHTTPServer) that serves WSGI applications", so this should not only works, but also it's expected to work... I think the issue is in the Mock object used in the test. |
|
+1 for this - I just tried to use port 0 because that's the normal way to get a random free port reliably. |
|
Does this cause issues with the registered callback URL? |
|
No it does not - the google implementation explicitly allows random ports for local host. |
|
Cool. Once we get the tests passing I'm happy to merge.
…On Tue, Jul 24, 2018, 3:03 PM Will Rouesnel ***@***.***> wrote:
No it does not - the google implementation explicitly allows random ports
for local host.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUczyijSMC9brz7rc4SPwjqg_z4jBeks5uJ5mYgaJpZM4QphOo>
.
|
|
Superseded by #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can have the system to allocate a random free TCP port by providing a value of "0" (int) to the port.
If you try this in the current code, the callback fails because the URL hardcode port "0", which is wrong.
This is quite easy to fix, by performing these two operations: