Skip to content

feat: resolve window.google #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2021
Merged

feat: resolve window.google #291

merged 3 commits into from
Jun 11, 2021

Conversation

jpoehnelt
Copy link
Contributor

@jpoehnelt jpoehnelt commented Jun 11, 2021

closes #224 by resolving to window.google

loader
  .load()
  .then((google) => {
    new google.maps.Map(document.getElementById("map"), mapOptions);
  })
  .catch(e => {
    // do something
  });

@snippet-bot
Copy link

snippet-bot bot commented Jun 11, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #291 (21face2) into master (0845116) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #291   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          123       123           
  Branches        25        25           
=========================================
  Hits           123       123           
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0845116...21face2. Read the comment docs.

@jpoehnelt jpoehnelt force-pushed the feat/resolve-google branch from a0f7afc to 9ec0883 Compare June 11, 2021 18:48
@jpoehnelt jpoehnelt merged commit cf6c3fb into master Jun 11, 2021
@jpoehnelt jpoehnelt deleted the feat/resolve-google branch June 11, 2021 18:52
github-actions bot pushed a commit that referenced this pull request Jun 11, 2021
# [1.12.0](v1.11.4...v1.12.0) (2021-06-11)

### Features

* resolve promise to window.google ([#291](#291)) ([cf6c3fb](cf6c3fb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs should state how to access the google and maps object.
1 participant