Skip to content

fix: loader must not reset if successfully loaded #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

louisnow
Copy link
Contributor

Fixes #105 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2020
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #106 (8d9178d) into master (e0f6651) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          117       118    +1     
  Branches        24        24           
=========================================
+ Hits           117       118    +1     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a5909...ca961be. Read the comment docs.

@jpoehnelt jpoehnelt merged commit 57180c8 into googlemaps:master Nov 17, 2020
github-actions bot pushed a commit that referenced this pull request Nov 17, 2020
## [1.11.1](v1.11.0...v1.11.1) (2020-11-17)

### Bug Fixes

* loader must not reset if successfully loaded ([#106](#106)) ([57180c8](57180c8))
@github-actions
Copy link

🎉 This PR is included in version 1.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loader with x retries will reset if it failed x times but succeeded the once
2 participants