Skip to content

fix: move warning and return if already defined #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

jpoehnelt
Copy link
Contributor

@jpoehnelt jpoehnelt commented Apr 28, 2021

closes #244

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #250 (f949982) into master (c66435c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #250   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          122       123    +1     
  Branches        25        25           
=========================================
+ Hits           122       123    +1     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66435c...f949982. Read the comment docs.

@jpoehnelt jpoehnelt merged commit af85dc8 into master Apr 28, 2021
@jpoehnelt jpoehnelt deleted the fix/warning-google-maps-loaded branch April 28, 2021 17:08
github-actions bot pushed a commit that referenced this pull request Apr 28, 2021
## [1.11.4](v1.11.3...v1.11.4) (2021-04-28)

### Bug Fixes

* move warning and return if already defined ([#250](#250)) ([af85dc8](af85dc8))
@github-actions
Copy link

🎉 This PR is included in version 1.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How can I dismiss this warning "Google Maps already loaded outside @googlemaps/js-api-loader
1 participant