Some Android devices fail to execute task callback

[lukezbihlyj]

We're currently having an issue affecting a significant number of Android users on various devices.

Some devices simply fail to execute the callback for the SignIn function, which causes the app to be waiting indefinitely for a response from the login process. We don't have this issue on iOS and a good percentage of our Android logins succeed just fine, including my test device.

I managed to reproduce the issue using Bluestacks emulator (version 3N) on a production release of our app. It seems that the login actually succeeds, and googlesignin-native logs some details about the user, but the C# wrapper never receives any data. Here is a logfile from the failed login attempt:

06-12 15:11:26.501  3396  3396 D TokenPendingResult:  Calling onResult for callback. result: Status: Status{statusCode=SUCCESS, resolution=null} com.google.android.gms.auth.api.signin.GoogleSignInAccount@b5b33152
06-12 15:11:26.501  3396  3396 I native-googlesignin: StringFromJava Luke Zbihlyj == Luke Zbihlyj
06-12 15:11:26.501  3396  3396 I native-googlesignin: StringFromJava [valid email redacted]
06-12 15:11:26.501  3396  3396 I native-googlesignin: StringFromJava Zbihlyj == Zbihlyj
06-12 15:11:26.501  3396  3396 I native-googlesignin: StringFromJava Luke == Luke
06-12 15:11:26.501  3396  3396 I native-googlesignin: StringFromJava [valid user id redacted]
06-12 15:11:26.501  3396  3396 I native-googlesignin: StringFromJava [valid avatar redacted]
06-12 15:11:26.501  3396  3396 I native-googlesignin: StringFromJava [valid auth code redacted]
06-12 15:11:26.501  3396  3396 I native-googlesignin: User Display Name is  Luke Zbihlyj
06-12 15:11:26.555  2178  2178 D GuidanceScreen..AppLaunchReceiver: same as previous package, returning to app
...
06-12 15:11:26.589  3396  3625 W FlurryAgent: Flurry session paused for context:com.google.android.gms.auth.api.signin.internal.SignInHubActivity@786920b
06-12 15:11:26.646  3396  4075 D AudioTrack: Client defaulted notificationFrames to 756 for frameCount 2270
06-12 15:11:26.651  1658  1668 I audio_hw_primary: choose pcmC0D0p for 0
06-12 15:11:26.673  1658  1668 D AudioFlinger: mixer(0xb16171c0) throttle end: throttle time(40)
06-12 15:11:26.681  1733  2348 D ActivityManager: cleanUpApplicationRecord -- 3555
06-12 15:11:26.732  1658  1668 D AudioFlinger: mixer(0xb16171c0) throttle end: throttle time(40)
06-12 15:11:26.743  1521  1521 W SurfaceFlinger: couldn't log to binary event log: overflow.

When I execute it on my working Android device I get the following:

06-12 01:02:02.266 23097 23097 D TokenPendingResult:  Calling onResult for callback. result: Status: Status{statusCode=SUCCESS, resolution=null} com.google.android.gms.auth.api.signin.GoogleSignInAccount@f5bad294
06-12 01:02:02.266 23097 23097 I native-googlesignin: StringFromJava Luke Zbihlyj == Luke Zbihlyj
06-12 01:02:02.266 23097 23097 I native-googlesignin: StringFromJava [valid email redacted]
06-12 01:02:02.266 23097 23097 I native-googlesignin: StringFromJava Zbihlyj == Zbihlyj
06-12 01:02:02.266 23097 23097 I native-googlesignin: StringFromJava Luke == Luke
06-12 01:02:02.266 23097 23097 I native-googlesignin: StringFromJava [valid user id redacted]
06-12 01:02:02.266 23097 23097 I native-googlesignin: StringFromJava [valid avatar redacted]
06-12 01:02:02.266 23097 23097 I native-googlesignin: StringFromJava [valid auth code redacted]
06-12 01:02:02.266 23097 23097 I native-googlesignin: User Display Name is  Luke Zbihlyj
06-12 01:02:02.266 23097 23097 D Typeface: fontPath:
06-12 01:02:02.276  2680  2697 D BatteryStatsImpl: Power Add Start sensor:  sensor id 1 uid is 10189
06-12 01:02:02.306  2680  2605 D PhoneHolsterManager: int setscreenLock
06-12 01:02:02.316 23097 23186 W FlurryAgent: Flurry session paused for context:com.google.android.gms.auth.api.signin.internal.SignInHubActivity@2f2bb63
...
06-12 01:02:02.346 23097 23126 I native-googlesignin: In Wrapper display name is  Luke Zbihlyj
06-12 01:02:02.346  2680 14414 I SurfaceControl: destroy Surface com.google.android.gms/com.google.android.gms.auth.api.signin.ui.SignInActivity
06-12 01:02:02.346  2680 14414 D PhoneHolsterManager: int setscreenLock

Note the line: native-googlesignin: In Wrapper display name is Luke Zbihlyj - this doesn't get called on the emulator and I believe this is the same problem many of our users are experiencing where they never see any kind of message from us because we never receive a callback.

If anyone else is having the same issue, or any devs on this project from Google can assist in this issue it would be much appreciated.

[doggan]

Were you able to figure anything out?

I am seeing cases where querying the result from the completed task (e.g. result.Result.IdToken) hangs. It seems like there is a Wait() that doesn't return.

[sabdul-khabir]

I'm seeing the same issue on an ASUS ZenFone 2E. I build the apk using Unity 2018.2.8 (Gradle,IL2CPP,SplitAPK). Somehow the Pending flag somehow never switches to false.

google-signin-unity/GoogleSignInPlugin/Assets/GoogleSignIn/Future.cs

Lines 72 to 82 in 588c063

	internal IEnumerator WaitForResult(TaskCompletionSource<T> tcs) {
	yield return new WaitUntil(() => !Pending);
	if (Status == GoogleSignInStatusCode.Canceled) {
	tcs.SetCanceled();
	} else if (Status == GoogleSignInStatusCode.Success ||
	Status == GoogleSignInStatusCode.SuccessCached) {
	tcs.SetResult(Result);
	} else {
	tcs.SetException(new GoogleSignIn.SignInException(Status));
	}
	}

If I insert an __android_log_print before returning in the method below, that seems to allow the wait to complete. Changing the return type to be an integer seems to work too.

google-signin-unity/native-googlesignin/src/main/cpp/google_signin_bridge.cc

Lines 143 to 145 in 588c063

	bool GoogleSignIn_Pending(GoogleSignInFuture_t self) {
	return self->wrapped_->Pending();
	}

Adding the attribute [return: MarshalAs (UnmanagedType.I1)] to the declaration fixes this issue. I'd recommend trying this first.

google-signin-unity/GoogleSignInPlugin/Assets/GoogleSignIn/Impl/GoogleSignInImpl.cs

Lines 133 to 134 in 588c063

	[DllImport(DllName)]
	internal static extern bool GoogleSignIn_Pending(HandleRef self);

[Anheurystics]

I began experiencing this as well when I upgraded to Unity 2018.3, and started using .NET Framework 4.x. for the devs who experienced this, were you also targeting 4.x?

[lukezbihlyj]

I never got anywhere figuring this issue out, but to add some context that issue was occurring on 2017.4.4f1 and is still occurring after we updated the project to 2018.2.19f1 recently (targeting .NET 3.5).

[sabdul-khabir]

We are also targeting .NET Framework 4.x. Our particular issue was a marshaling/interop problem similar to this . We ended up modifying the plugin source in GoogleSignInImpl.cs to:

[DllImport(DllName)]
[return: MarshalAs (UnmanagedType.I1)]
internal static extern bool GoogleSignIn_Pending(HandleRef self);

[puetsua]

I have same problem too. I'm using Unity 2018.3.14f with NET 4.x and IL2CPP.

I tried @sulaiman-nixhydra 's solution but no luck. :c

[tonyisid]

We are also targeting .NET Framework 4.x. Our particular issue was a marshaling/interop problem similar to this . We ended up modifying the plugin source in GoogleSignInImpl.cs to:

[DllImport(DllName)]
[return: MarshalAs (UnmanagedType.I1)]
internal static extern bool GoogleSignIn_Pending(HandleRef self);

I have the some problem too. I'm using Unity 2019.2.17f1 with .NET4.5 and IL2CPP. I use this resolution, it works when I build apk, but it not works when I upload to Google Play.