This repository was archived by the owner on Nov 5, 2024. It is now read-only.
feat: add helper for sqlite credential store #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
drpebcak,
thedadams,
StrongMonkey,
iwilltry42 and
tylerslaton
drpebcak
approved these changes
Sep 20, 2024
Signed-off-by: Grant Linville <[email protected]>
| type GptscriptCredential struct { | ||
| ID uint `gorm:"primary_key"` | ||
| CreatedAt time.Time | ||
| ServerURL string `gorm:"unique"` |
There was a problem hiding this comment.
What is the serverURL in credential?
There was a problem hiding this comment.
This is so that we fit logically with how credentials work for the Docker credential helpers. Each Docker credential includes a server URL, username, and password. The server URL is basically the URL of the container store. In our case we use the server URL as a combination of the credential context and credential name. But the translation of that is handled in GPTScript itself, not here in the helper.
StrongMonkey
approved these changes
Sep 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new application to support using a local SQLite database for credential storage with GPTScript. It works just like the Docker credential helpers that we use, and implements the same interface.
I have not integrated this as a credential store option in GPTScript yet. That is the next step for me. I wanted to get the code up here in order to make testing a bit easier.
I'll add some documentation about how to use this and how to set up encryption configuration once I have everything working.