enhance: add green color to tool call names #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
ibuildthecloud,
thedadams,
njhale,
StrongMonkey,
iwilltry42,
keyallis and
tylerslaton
njhale
approved these changes
Mar 25, 2024
| @@ -34,6 +35,7 @@ type GPTScript struct { | |||
| CacheOptions | |||
| OpenAIOptions | |||
| DisplayOptions | |||
| Color *bool `usage:"Use color in output (default true)" default:"true"` | |||
There was a problem hiding this comment.
nit: can this just be a bool instead of *bool?
There was a problem hiding this comment.
I was following the example of the --cache flag, which you can see here:
Line 21 in fd7e77d
It uses a bool pointer. I noticed that when I had just a bool, the default:"true" struct tag didn't do anything, but it worked as soon as I made it a pointer.
There was a problem hiding this comment.
Also I just noticed that the description for --cache is the opposite of what it's supposed to be, lol
thedadams
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #13
When scanning through the output of gptscript, I am usually most interested in finding the tool calls. I figured that making the tool names green would make it easier.
We could easily add more colors to the output as well, but I wasn't really sure what else to do.
Here's an example of what it looks like:
