Fix: fix golang packaging in windows #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
commented
Apr 8, 2024
| @@ -172,7 +172,7 @@ func (e *Engine) startDaemon(_ context.Context, tool types.Tool) (string, error) | |||
| e.Ports.daemonWG.Done() | |||
| }) | |||
|
|
|||
| for i := 0; i < 20; i++ { | |||
| for i := 0; i < 120; i++ { | |||
There was a problem hiding this comment.
Need to wait for more time to setup remote toolchain(like downloading runtime/pip install) before it can timeout
There was a problem hiding this comment.
@ibuildthecloud The problem is that today when we use clicky-chat to download knowledge-api, the clicky-chat daemon will timeout first before it can download the other runtime(python). Ideally this timeout could probably be higher to give more time to download.
StrongMonkey
commented
Apr 8, 2024
| @@ -202,6 +203,17 @@ func (e *Engine) newCommand(ctx context.Context, extraEnv []string, tool types.T | |||
| cmdArgs = append(cmdArgs, f.Name()) | |||
| } | |||
|
|
|||
| // This is a workaround for Windows, where the command interpreter is constructed with unix style paths | |||
| // It converts unix style paths to windows style paths | |||
There was a problem hiding this comment.
This only converts the first arg (which is ${GPTSCRIPT_TOOL_DIR}/bin/gptscript-go-tool)`. There could be some edge cases where the rest of the args contain unix path, which is not addressed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed some bugs around packaging and invoking golang runtime in windows.