fix: credentials: don't store creds for local credential tools #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
thedadams,
njhale,
StrongMonkey,
iwilltry42,
keyallis and
tylerslaton
njhale
approved these changes
Apr 12, 2024
pkg/runner/runner.go
Outdated
| ) | ||
|
|
||
| // Only try to look up the cred if the tool is on GitHub. | ||
| if strings.HasPrefix(credToolName, "github.com") { |
There was a problem hiding this comment.
nit: I suggest using a constant instead of a literal since we're using it in multiple places.
There was a problem hiding this comment.
Fixed. Decided to just define a function.
Signed-off-by: Grant Linville <[email protected]>
thedadams
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #240
There was a problem where sometimes credential tools without
git.godevs.topat the front of their name were having their credentials stored anyway. This change also skips the credential lookup for non-GitHub tools, since we aren't going to store the credentials for those anyway.