fix: infinite loop while creating gptscript toolset based on name #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool names have to be unique, so if two tools are added with the same name, they have a 0 appended to them. In this case we got into an infinite loop because toolName was incremented not the variable under test. So we ended up in an infite loop. Signed-off-by: Bill Maxwell <[email protected]>
g-linville
approved these changes
Jun 7, 2024
StrongMonkey
approved these changes
Jun 7, 2024
njhale
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool names have to be unique, so if two tools are added with the same name, they have a 0 appended to them. In this case we got into an infinite loop because toolName was incremented not the variable under test. So we ended up in an infite loop.