Skip to content

bug: don't capture stderr for cred and provider tools #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2024
Merged

bug: don't capture stderr for cred and provider tools #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions pkg/engine/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,21 +134,28 @@ func (e *Engine) runCommand(ctx Context, tool types.Tool, input string, toolCate
},
}

result := &bytes.Buffer{}
all := io.MultiWriter(result, &outputWriter{
id: id,
progress: e.Progress,
})

cmd.Stdout = all
cmd.Stderr = all
if log.IsDebug() {
cmd.Stderr = io.MultiWriter(all, os.Stderr)
var (
stdout = &bytes.Buffer{}
stdoutAndErr = &bytes.Buffer{}
progressOut = &outputWriter{
id: id,
progress: e.Progress,
}
result *bytes.Buffer
)

cmd.Stdout = io.MultiWriter(stdout, stdoutAndErr, progressOut)
if toolCategory == NoCategory || toolCategory == ContextToolCategory {
cmd.Stderr = io.MultiWriter(stdoutAndErr, progressOut)
result = stdoutAndErr
} else {
cmd.Stderr = io.MultiWriter(stdoutAndErr, progressOut, os.Stderr)
result = stdout
}

if err := cmd.Run(); err != nil {
if toolCategory == NoCategory {
return fmt.Sprintf("ERROR: got (%v) while running tool, OUTPUT: %s", err, result), nil
return fmt.Sprintf("ERROR: got (%v) while running tool, OUTPUT: %s", err, stdoutAndErr), nil
}
log.Errorf("failed to run tool [%s] cmd %v: %v", tool.Parameters.Name, cmd.Args, err)
return "", fmt.Errorf("ERROR: %s: %w", result, err)
Expand Down