Skip to content

Drop unneeded code as vision is being moved to a tool #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
.DEFAULT_GOAL := build

all: build-ui build

build-ui:
Expand Down
9 changes: 2 additions & 7 deletions pkg/builtin/defaults.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,12 @@ import (
)

var (
DefaultModel = openai.DefaultModel
DefaultVisionModel = openai.DefaultVisionModel
DefaultModel = openai.DefaultModel
)

func SetDefaults(tool types.Tool) types.Tool {
if tool.Parameters.ModelName == "" {
if tool.Parameters.Vision {
tool.Parameters.ModelName = DefaultVisionModel
} else {
tool.Parameters.ModelName = DefaultModel
}
tool.Parameters.ModelName = DefaultModel
}
return tool
}
1 change: 0 additions & 1 deletion pkg/engine/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ func (e *Engine) Start(ctx Context, input string) (*Return, error) {

completion := types.CompletionRequest{
Model: tool.Parameters.ModelName,
Vision: tool.Parameters.Vision,
MaxToken: tool.Parameters.MaxTokens,
JSONResponse: tool.Parameters.JSONResponse,
Cache: tool.Parameters.Cache,
Expand Down
60 changes: 15 additions & 45 deletions pkg/openai/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,10 @@ import (
"github.com/gptscript-ai/gptscript/pkg/cache"
"github.com/gptscript-ai/gptscript/pkg/hash"
"github.com/gptscript-ai/gptscript/pkg/types"
"github.com/gptscript-ai/gptscript/pkg/vision"
"github.com/sashabaranov/go-openai"
)

const (
DefaultVisionModel = openai.GPT4VisionPreview
DefaultModel = openai.GPT4TurboPreview
DefaultPromptParameter = "defaultPromptParameter"
)
Expand Down Expand Up @@ -171,15 +169,8 @@ func toToolCall(call types.CompletionToolCall) openai.ToolCall {
}
}

func toMessages(cache *cache.Client, request types.CompletionRequest) (result []openai.ChatCompletionMessage, err error) {
func toMessages(request types.CompletionRequest) (result []openai.ChatCompletionMessage, err error) {
for _, message := range request.Messages {
if request.Vision {
message, err = vision.ToVisionMessage(cache, message)
if err != nil {
return nil, err
}
}

chatMessage := openai.ChatCompletionMessage{
Role: string(message.Role),
}
Expand All @@ -192,25 +183,6 @@ func toMessages(cache *cache.Client, request types.CompletionRequest) (result []
if content.ToolCall != nil {
chatMessage.ToolCalls = append(chatMessage.ToolCalls, toToolCall(*content.ToolCall))
}
if content.Image != nil {
url, err := vision.ImageToURL(cache, request.Vision, *content.Image)
if err != nil {
return nil, err
}
if request.Vision {
chatMessage.MultiContent = append(chatMessage.MultiContent, openai.ChatMessagePart{
Type: openai.ChatMessagePartTypeImageURL,
ImageURL: &openai.ChatMessageImageURL{
URL: url,
},
})
} else {
chatMessage.MultiContent = append(chatMessage.MultiContent, openai.ChatMessagePart{
Type: openai.ChatMessagePartTypeText,
Text: fmt.Sprintf("Image URL %s", url),
})
}
}
if content.Text != "" {
chatMessage.MultiContent = append(chatMessage.MultiContent, openai.ChatMessagePart{
Type: openai.ChatMessagePartTypeText,
Expand Down Expand Up @@ -251,7 +223,7 @@ type Status struct {
}

func (c *Client) Call(ctx context.Context, messageRequest types.CompletionRequest, status chan<- Status) (*types.CompletionMessage, error) {
msgs, err := toMessages(c.cache, messageRequest)
msgs, err := toMessages(messageRequest)
if err != nil {
return nil, err
}
Expand All @@ -277,21 +249,19 @@ func (c *Client) Call(ctx context.Context, messageRequest types.CompletionReques
}
}

if !messageRequest.Vision {
for _, tool := range messageRequest.Tools {
params := tool.Function.Parameters
if params != nil && params.Type == "object" && params.Properties == nil {
params.Properties = map[string]types.Property{}
}
request.Tools = append(request.Tools, openai.Tool{
Type: openai.ToolType(tool.Type),
Function: openai.FunctionDefinition{
Name: tool.Function.Name,
Description: tool.Function.Description,
Parameters: params,
},
})
for _, tool := range messageRequest.Tools {
params := tool.Function.Parameters
if params != nil && params.Type == "object" && params.Properties == nil {
params.Properties = map[string]types.Property{}
}
request.Tools = append(request.Tools, openai.Tool{
Type: openai.ToolType(tool.Type),
Function: openai.FunctionDefinition{
Name: tool.Function.Name,
Description: tool.Function.Description,
Parameters: params,
},
})
}

id := fmt.Sprint(atomic.AddInt64(&completionID, 1))
Expand Down Expand Up @@ -368,7 +338,7 @@ func appendMessage(msg types.CompletionMessage, response openai.ChatCompletionSt
if delta.Content != "" {
found := false
for i, content := range msg.Content {
if content.ToolCall != nil || content.Image != nil {
if content.ToolCall != nil {
continue
}
msg.Content[i] = types.ContentPart{
Expand Down
5 changes: 0 additions & 5 deletions pkg/parser/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,6 @@ func isParam(line string, tool *types.Tool) (_ bool, err error) {
if err := addArg(value, tool); err != nil {
return false, err
}
case "vision":
tool.Parameters.Vision, err = toBool(value)
if err != nil {
return false, err
}
case "maxtoken":
fallthrough
case "maxtokens":
Expand Down
28 changes: 0 additions & 28 deletions pkg/types/completion.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ type CompletionToolType string

type CompletionRequest struct {
Model string
Vision bool
Tools []CompletionTool
Messages []CompletionMessage
MaxToken int
Expand Down Expand Up @@ -77,40 +76,13 @@ func (in CompletionMessage) String() string {
if content.ToolCall != nil {
buf.WriteString(fmt.Sprintf("tool call %s -> %s", content.ToolCall.Function.Name, content.ToolCall.Function.Arguments))
}
if content.Image != nil {
buf.WriteString("image: ")
if content.Image.URL != "" {
buf.WriteString(content.Image.URL)
}
if len(content.Image.Base64) > 50 {
buf.WriteString(content.Image.Base64[:50] + "...")
} else {
buf.WriteString(content.Image.Base64)
}
}
}
return buf.String()
}

type ContentPart struct {
Text string `json:"text,omitempty"`
ToolCall *CompletionToolCall `json:"toolCall,omitempty"`
Image *ImageURL `json:"image,omitempty"`
}

type ImageURLDetail string

const (
ImageURLDetailHigh ImageURLDetail = "high"
ImageURLDetailLow ImageURLDetail = "low"
ImageURLDetailAuto ImageURLDetail = "auto"
)

type ImageURL struct {
Base64 string `json:"base64,omitempty"`
ContentType string `json:"contentType,omitempty"`
URL string `json:"url,omitempty"`
Detail ImageURLDetail `json:"detail,omitempty"`
}

type CompletionToolCall struct {
Expand Down
4 changes: 0 additions & 4 deletions pkg/types/tool.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ type BuiltinFunc func(ctx context.Context, env []string, input string) (string,
type Parameters struct {
Name string `json:"name,omitempty"`
Description string `json:"description,omitempty"`
Vision bool `json:"vision,omitempty"`
MaxTokens int `json:"maxTokens,omitempty"`
ModelName string `json:"modelName,omitempty"`
JSONResponse bool `json:"jsonResponse,omitempty"`
Expand Down Expand Up @@ -59,9 +58,6 @@ func (t Tool) String() string {
if len(t.Parameters.Tools) != 0 {
_, _ = fmt.Fprintf(buf, "Tools: %s\n", strings.Join(t.Parameters.Tools, ", "))
}
if t.Parameters.Vision {
_, _ = fmt.Fprintln(buf, "Vision: true")
}
if t.Parameters.MaxTokens != 0 {
_, _ = fmt.Fprintf(buf, "Max Tokens: %d\n", t.Parameters.MaxTokens)
}
Expand Down
99 changes: 0 additions & 99 deletions pkg/vision/image.go

This file was deleted.

39 changes: 0 additions & 39 deletions pkg/vision/schema.go

This file was deleted.