-
Notifications
You must be signed in to change notification settings - Fork 300
enhance: add support for azure deployment name mapping #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add support for azure deployment name mapping #78
Conversation
@keyallis thank you for this PR! I tried use your changes already locally however I ran into the situation that gptscript is waiting for the model response "for ever":
Have you ran into this to sometimes? |
Hey @danielhass, thanks for taking a look. I'm curious what variables you're setting when testing this? These are the ones I have set:
If you don't have all of these set then it might not be picking up the changes included |
README.md
Outdated
|
||
```shell | ||
export OPENAI_API_KEY="your-api-key" | ||
export OPENAI_URL="your-endpiont" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this different than OPENAI_BASE_URL
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we already have both, but this version does not match the help text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just the env var I was using. I can swap it.
@keyallis I used the following set of env vars:
|
@danielhass I believe your issue might be with the |
@keyallis 💯 - changing to Shall we add this to the docs for the Azure variant? |
@danielhass I've omitted mention of the |
@keyallis didn't know about the default. Makes total sense not to mention it in that case 👍 Thanks for bringing this to gptscript! |
#43
Add a configurable env variable to set the azure deployment name to be used in lieu of the model name. Migrate away from using the snapshotted fork of
go-openai
, and add a hack for passing temperature.