-
Notifications
You must be signed in to change notification settings - Fork 31
Replace direct call to levitate with usage of is-compatible github workflow #1909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Left one comment as I'm not sure if the yaml package is removing some character escaping that exists in the scaffolded file.
packages/create-plugin/src/migrations/scripts/002-update-is-compatible-workflow.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Took it for a quick spin in this PR...
Co-authored-by: Levente Balogh <[email protected]>
Co-authored-by: Levente Balogh <[email protected]>
Co-authored-by: Levente Balogh <[email protected]>
🚀 PR was released in |
What this PR does / why we need it:
It replaces the direct levitate call with our own github action is-compatible
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via: