store: Fix a mistake in how pruning status is reported #6062
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isum
approved these changes
Jun 23, 2025
When we start copying nonfinal entities, we need to reset the start_vid and next_vid. They don't necessarily have a direct connection to the same values for nonfinal entities; e.g., it is possible that the start_vid for nonfinal entities is smaller than the one for final entities. This change only affects how we report the completion of prune operations; it has no effect on what gets pruned and how.
lutter
force-pushed
the
lutter/prune-status
branch
from
b499f3a to
97992cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we start copying nonfinal entities, we need to reset the start_vid and next_vid. They don't necessarily have a direct connection to the same values for nonfinal entities; e.g., it is possible that the start_vid for nonfinal entities is smaller than the one for final entities.
This change only affects how we report the completion of prune operations; it has no effect on what gets pruned and how.