Make compatible with other JVM Locales as for example turkish. #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capitalize() without Locale.ENGLISH leads to unexpected chars which are language specific
|
I'd maybe use |
capitalize() without Locale.ROOT leads to unexpected chars which are language specific
Seems to be the "better" approach, done |
florensie
suggested changes
Apr 23, 2021
src/main/kotlin/graphql/kickstart/tools/resolver/FieldResolverScanner.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/graphql/kickstart/tools/FieldResolverScannerTest.kt
Outdated
Show resolved
Hide resolved
capitalize() without Locale.ROOT leads to unexpected chars which are language specific Review changes
florensie
previously approved these changes
Apr 26, 2021
janitza-bjag
commented
Apr 27, 2021
vojtapol
previously approved these changes
Apr 27, 2021
|
Is there anything to do for me? |
|
Looks like |
|
@janitza-bjag lets replace these with |
capitalize() without Locale.ROOT leads to unexpected chars which are language specific Review changes
capitalize() without Locale.ROOT leads to unexpected chars which are language specific Review changes
janitza-bjag
commented
May 20, 2021
oryan-block
requested changes
May 20, 2021
| fun `scanner finds field resolver method using capitalize field_name`() { | ||
| val resolver = RootResolverInfo(listOf(CapitalizeQuery()), options) | ||
|
|
||
| val meta = scanner.findFieldResolver(FieldDefinition("id", TypeName("HullType")), resolver) |
There was a problem hiding this comment.
Lets make sure the test will fail on all machines by setting the default locale to Turkish Locale.forLanguageTag("tr-TR") and resetting it back to default at the end.
And add a comment to explain why we do that please.
|
Closing this since we're unable to push/merge it as it is. Opened #565 with the same commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
capitalize() without Locale.ENGLISH leads to unexpected chars which are language specific
Checklist
Description